Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include alert_status in travel advice example #233

Merged
merged 1 commit into from Feb 10, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 10, 2016

This is a feature in the travel advice format that FCO publishers don’t appear to be using at the moment. However they could begin using it and it would render a block on the front-end, so an appropriate example should be included.

cc @dsingleton

This is a feature in the travel advice format that FCO publishers don’t
appear to be using at the moment. However they could begin using it, so
an example should be included.
@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented Feb 10, 2016

👍 to having examples covering possible cases.

It's a bit weird that the field is an array, rather than a single value, and the value is free text, not an enum, to avoid issues like typos, as we do on some other formats. But thats all well out of scope of this change, so merging.

dsingleton added a commit that referenced this pull request Feb 10, 2016
Include alert_status in travel advice example
@dsingleton dsingleton merged commit 3dd62e5 into master Feb 10, 2016
16 checks passed
16 checks passed
Specialist frontend contract tests Build #482 succeeded on Jenkins
Details
Verify collections against content schemas Build #608 succeeded on Jenkins
Details
Verify collections-publisher against content schemas Build #582 succeeded on Jenkins
Details
Verify contacts-admin against content schemas Build #716 succeeded on Jenkins
Details
Verify contacts-frontend against content schemas Build #245 succeeded on Jenkins
Details
Verify government-frontend against content format examples Build #747 succeeded on Jenkins
Details
Verify hmrc-manuals-api against content schemas Build #400 succeeded on Jenkins
Details
Verify manuals-frontend against schema examples Build #576 succeeded on Jenkins
Details
Verify publisher against content schemas Build #633 succeeded on Jenkins
Details
Verify specialist-publisher against content schemas Build #680 succeeded on Jenkins
Details
Verify static components against schema examples Build #116 succeeded on Jenkins
Details
Verify travel-advice-publisher against content schemas Build #382 succeeded on Jenkins
Details
default Build #701 succeeded on Jenkins
Details
finder frontend contract tests Build #745 succeeded on Jenkins
Details
policy publisher contract tests Build #741 succeeded on Jenkins
Details
whitehall contract tests Build #794 succeeded on Jenkins
Details
@dsingleton dsingleton deleted the alert-status-in-travel-advice branch Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.