Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withdrawn notices to detailed guides #288

Merged
merged 2 commits into from Apr 22, 2016
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 22, 2016

  • Base on case studies withdrawn pattern
  • Add withdrawn detailed guide example
  • Extract withdrawn notice into a definition so it is consistently used
  • Update detailed guides and case studies to use this definition

Part of:
https://trello.com/c/P2CLsRtp/383-6-detailed-guides-migration-front-end-work-withdrawing-documents-small

fofr added 2 commits Apr 22, 2016
* Base on case studies withdrawn pattern
* Add withdrawn detailed guide example
* Extract withdrawn notice into a definition so it is consistently used
* Update detailed guides and case studies to use this definition
@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented Apr 22, 2016

👍 for the de-duping, LGTM.

@dsingleton dsingleton merged commit 68c9774 into master Apr 22, 2016
17 checks passed
17 checks passed
Specialist frontend contract tests Build #712 succeeded on Jenkins
Details
Verify collections against content schemas Build #825 succeeded on Jenkins
Details
Verify collections-publisher against content schemas Build #812 succeeded on Jenkins
Details
Verify contacts-admin against content schemas Build #946 succeeded on Jenkins
Details
Verify contacts-frontend against content schemas Build #481 succeeded on Jenkins
Details
Verify government-frontend against content format examples Build #964 succeeded on Jenkins
Details
Verify hmrc-manuals-api against content schemas Build #630 succeeded on Jenkins
Details
Verify manuals-frontend against schema examples Build #806 succeeded on Jenkins
Details
Verify publisher against content schemas Build #863 succeeded on Jenkins
Details
Verify specialist-publisher against content schemas Build #912 succeeded on Jenkins
Details
Verify specialist-publisher-rebuild against content schemas Build #33 succeeded on Jenkins
Details
Verify static components against schema examples Build #346 succeeded on Jenkins
Details
Verify travel-advice-publisher against content schemas Build #612 succeeded on Jenkins
Details
default Build #898 succeeded on Jenkins
Details
finder frontend contract tests Build #963 succeeded on Jenkins
Details
policy publisher contract tests Build #972 succeeded on Jenkins
Details
whitehall contract tests Build #1018 succeeded on Jenkins
Details
@dsingleton dsingleton deleted the withdrawable-detailed-guides branch Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.