Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add government and political fields to detailed guides #290

Merged
merged 2 commits into from Apr 26, 2016
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 25, 2016

The plan is to allow government to be a link, so that current, names and slugs can be updated automatically without having to republish. However governments represent URL-less content, which the content store doesn’t currently handle.

As an intermediate to unblock detailed guides, put government into the details hash instead.

  • From government and political, logic that determines if the history banner should show can be derived.
  • Government slug needed for analytics
  • Include example of a political detailed guide

Political example based on:
https://www.gov.uk/guidance/onshore-wind-part-of-the-uks-energy-mix

Part of:
https://trello.com/c/74ymVfIw/384-6-detailed-guides-migration-front-end-work-for-history-mode-political-status-and-government-small

@@ -52,6 +73,10 @@
}
}
},
"political": {
"type": "boolean",
"description": "If the content is considered political in nature, relfecting views of the government it was published under."

This comment has been minimized.

@boffbowsh

boffbowsh Apr 25, 2016
Contributor

Typo, "reflecting".

@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Apr 25, 2016

Minor typo, otherwise 👍

fofr added 2 commits Apr 25, 2016
The plan is to allow government to be a link, so that `current`, names
and slugs can be updated automatically without having to republish.
However governments represent URL-less content, which the content store
doesn’t currently handle.

As an intermediate to unblock detailed guides, put government into the
details hash instead.

From `government` and `political`, whether the history banner should
show can be derived.
* Make them required fields
* Update existing examples to include fields
* Include example of political content (also an example of something
that’s not had any updates)

Political example based on:
https://www.gov.uk/guidance/onshore-wind-part-of-the-uks-energy-mix
@fofr fofr force-pushed the history-mode branch from 5478be8 to 4c63fbd Apr 25, 2016
@fofr
Copy link
Contributor Author

@fofr fofr commented Apr 25, 2016

@boffbowsh Typo fixed.

@fofr fofr changed the title Add government and political fields to detailed guides [Do not merge] Add government and political fields to detailed guides Apr 25, 2016
@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented Apr 25, 2016

👍

fofr added a commit to alphagov/static that referenced this pull request Apr 25, 2016
* Derive political status based on current-ness of government and
political state of content
* Only include analytics tags if both government and political keys are
present

Based on political and government representations in content items,
added in: alphagov/govuk-content-schemas#290
@tvararu
Copy link
Contributor

@tvararu tvararu commented Apr 26, 2016

Looks good to me. 👍

@fofr fofr changed the title [Do not merge] Add government and political fields to detailed guides Add government and political fields to detailed guides Apr 26, 2016
@fofr fofr merged commit 39c468e into master Apr 26, 2016
17 checks passed
17 checks passed
Specialist frontend contract tests Build #716 succeeded on Jenkins
Details
Verify collections against content schemas Build #829 succeeded on Jenkins
Details
Verify collections-publisher against content schemas Build #816 succeeded on Jenkins
Details
Verify contacts-admin against content schemas Build #950 succeeded on Jenkins
Details
Verify contacts-frontend against content schemas Build #485 succeeded on Jenkins
Details
Verify government-frontend against content format examples Build #968 succeeded on Jenkins
Details
Verify hmrc-manuals-api against content schemas Build #634 succeeded on Jenkins
Details
Verify manuals-frontend against schema examples Build #810 succeeded on Jenkins
Details
Verify publisher against content schemas Build #867 succeeded on Jenkins
Details
Verify specialist-publisher against content schemas Build #916 succeeded on Jenkins
Details
Verify specialist-publisher-rebuild against content schemas Build #37 succeeded on Jenkins
Details
Verify static components against schema examples Build #350 succeeded on Jenkins
Details
Verify travel-advice-publisher against content schemas Build #616 succeeded on Jenkins
Details
default Build #902 succeeded on Jenkins
Details
finder frontend contract tests Build #967 succeeded on Jenkins
Details
policy publisher contract tests Build #976 succeeded on Jenkins
Details
whitehall contract tests Build #1022 succeeded on Jenkins
Details
@fofr fofr deleted the history-mode branch Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.