Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document collections to detailed guides, add examples of more features #293

Merged
merged 4 commits into from Apr 28, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 27, 2016

  • Add related guide to examples, to build frontend against
  • Add document collections to detailed guide schema, and include examples
  • Add examples of related mainstream content, document collections and related guides

Examples used:
https://www.gov.uk/guidance/onshore-wind-part-of-the-uks-energy-mix
https://www.gov.uk/guidance/living-in-fiji
https://www.gov.uk/guidance/living-in-fiji--2

Part of:
https://trello.com/c/k6H9gNKF/316-6-detailed-guides-migration-front-end-work-small

cc @mgrassotti @tvararu

fofr added 3 commits Apr 27, 2016
Allow the frontend to develop related detailed guides feature by
including a real-world example of the content from
https://www.gov.uk/guidance/onshore-wind-part-of-the-uks-energy-mix
Detailed guides can be part of document collections, we show this in
the “Part of” metadata component and in the document footer component
on the frontend.
@fofr
Copy link
Contributor Author

@fofr fofr commented Apr 27, 2016

Test failures appear unrelated?

@tvararu
Copy link
Contributor

@tvararu tvararu commented Apr 27, 2016

Yeah, test failures do appear to be unrelated.

Looks good. 👍

@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Apr 27, 2016

This copies a pattern from Case Studies, but that pattern isn't valid. Updates to the underlying document collection won't update the "Part of" metadata of the Case Study or Detailed guide.

@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Apr 28, 2016

This PR is going to bring Detailed guides document collections into line with Case studies, then we'll fix both in another PR.

@boffbowsh boffbowsh merged commit bc686ec into master Apr 28, 2016
16 of 17 checks passed
16 of 17 checks passed
Verify specialist-publisher-rebuild against content schemas Build #45 failed on Jenkins
Details
Specialist frontend contract tests Build #724 succeeded on Jenkins
Details
Verify collections against content schemas Build #837 succeeded on Jenkins
Details
Verify collections-publisher against content schemas Build #824 succeeded on Jenkins
Details
Verify contacts-admin against content schemas Build #958 succeeded on Jenkins
Details
Verify contacts-frontend against content schemas Build #493 succeeded on Jenkins
Details
Verify government-frontend against content format examples Build #976 succeeded on Jenkins
Details
Verify hmrc-manuals-api against content schemas Build #642 succeeded on Jenkins
Details
Verify manuals-frontend against schema examples Build #818 succeeded on Jenkins
Details
Verify publisher against content schemas Build #875 succeeded on Jenkins
Details
Verify specialist-publisher against content schemas Build #924 succeeded on Jenkins
Details
Verify static components against schema examples Build #358 succeeded on Jenkins
Details
Verify travel-advice-publisher against content schemas Build #624 succeeded on Jenkins
Details
default Build #907 succeeded on Jenkins
Details
finder frontend contract tests Build #975 succeeded on Jenkins
Details
policy publisher contract tests Build #984 succeeded on Jenkins
Details
whitehall contract tests Build #1030 succeeded on Jenkins
Details
@boffbowsh boffbowsh deleted the add-related-guide-examples branch Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.