Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove organisations and parent from HTML publications `links.json` #302

Merged
merged 1 commit into from May 10, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 5, 2016

These are provided by base_links, this is duplication – if one of these was changed (either base or the one in links) it might have unexpected results.

These are provided by `base_links`, this is duplication – if one of
these was changed (either base or the one in links) it might have
unexpected results.
@fofr fofr force-pushed the reduce-duplication-html-pubs branch from d27cd11 to aaa9828 May 9, 2016
@fofr
Copy link
Contributor Author

@fofr fofr commented May 9, 2016

Rebased with master.

"$ref": "#/definitions/guid_list"
}
}
"properties": {}

This comment has been minimized.

@boffbowsh

boffbowsh May 9, 2016
Contributor

I don't believe you need this line.

This comment has been minimized.

@fofr

fofr May 9, 2016
Author Contributor

You do, kind of …

vagrant@development:/var/govuk/govuk-content-schemas$ bundle exec rake
rake aborted!
NoMethodError: undefined method `merge' for nil:NilClass
/var/govuk-sites/govuk-content-schemas/lib/govuk_content_schemas/schema_combiner.rb:69:in `merge_schemas'
/var/govuk-sites/govuk-content-schemas/lib/govuk_content_schemas/schema_combiner.rb:60:in `add_links'
@boffbowsh boffbowsh merged commit 9a0bbde into master May 10, 2016
17 checks passed
17 checks passed
Specialist frontend contract tests Build #766 succeeded on Jenkins
Details
Verify collections against content schemas Build #879 succeeded on Jenkins
Details
Verify collections-publisher against content schemas Build #866 succeeded on Jenkins
Details
Verify contacts-admin against content schemas Build #1000 succeeded on Jenkins
Details
Verify contacts-frontend against content schemas Build #535 succeeded on Jenkins
Details
Verify government-frontend against content format examples Build #1018 succeeded on Jenkins
Details
Verify hmrc-manuals-api against content schemas Build #684 succeeded on Jenkins
Details
Verify manuals-frontend against schema examples Build #860 succeeded on Jenkins
Details
Verify publisher against content schemas Build #917 succeeded on Jenkins
Details
Verify specialist-publisher against content schemas Build #966 succeeded on Jenkins
Details
Verify specialist-publisher-rebuild against content schemas Build #91 succeeded on Jenkins
Details
Verify static components against schema examples Build #401 succeeded on Jenkins
Details
Verify travel-advice-publisher against content schemas Build #666 succeeded on Jenkins
Details
default Build #941 succeeded on Jenkins
Details
finder frontend contract tests Build #1017 succeeded on Jenkins
Details
policy publisher contract tests Build #1026 succeeded on Jenkins
Details
whitehall contract tests Build #1072 succeeded on Jenkins
Details
@boffbowsh boffbowsh deleted the reduce-duplication-html-pubs branch May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.