Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use document_type for "publication type" #303

Merged
merged 1 commit into from May 9, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 6, 2016

All publications use the schema or format “publication”, but have a required publication type – we can use document_type for this, as specified in RFC 41:
https://gov-uk.atlassian.net/wiki/pages/viewpage.action?spaceKey=GOVUK&title=RFC+41%3A+Separate+document+type+from+format

We will deprecate the current format field, and replace it with two new fields:
schema_name - determines which file in govuk-content-schemas is used to validate the item.
document_type - used for frontend display and for filtering in publishing apps “

(Although, in the case of publications, all document types look exactly the same – the only difference being the context string used in their title component. Semantics basically.)

All publications use the schema or format “publication”, but have a
required document type. Use `document_type` for this, as specified in
RFC 41:
https://gov-uk.atlassian.net/wiki/pages/viewpage.action?spaceKey=GOVUK&t
itle=RFC+41%3A+Separate+document+type+from+format

“We will deprecate the current format field, and replace it with two
new fields:
schema_name - determines which file in govuk-content-schemas is used to
validate the item.
document_type - used for frontend display and for filtering in
publishing apps “

(Although, in the case of publications, all document types look exactly
the same – they have a different context string in their title
component, that’s the only difference. Semantics basically.)
@fofr fofr closed this May 6, 2016
@fofr fofr reopened this May 6, 2016
@boffbowsh boffbowsh merged commit 76ad74d into master May 9, 2016
17 checks passed
17 checks passed
Specialist frontend contract tests Build #754 succeeded on Jenkins
Details
Verify collections against content schemas Build #867 succeeded on Jenkins
Details
Verify collections-publisher against content schemas Build #854 succeeded on Jenkins
Details
Verify contacts-admin against content schemas Build #988 succeeded on Jenkins
Details
Verify contacts-frontend against content schemas Build #523 succeeded on Jenkins
Details
Verify government-frontend against content format examples Build #1006 succeeded on Jenkins
Details
Verify hmrc-manuals-api against content schemas Build #672 succeeded on Jenkins
Details
Verify manuals-frontend against schema examples Build #848 succeeded on Jenkins
Details
Verify publisher against content schemas Build #905 succeeded on Jenkins
Details
Verify specialist-publisher against content schemas Build #954 succeeded on Jenkins
Details
Verify specialist-publisher-rebuild against content schemas Build #79 succeeded on Jenkins
Details
Verify static components against schema examples Build #389 succeeded on Jenkins
Details
Verify travel-advice-publisher against content schemas Build #654 succeeded on Jenkins
Details
default Build #933 succeeded on Jenkins
Details
finder frontend contract tests Build #1005 succeeded on Jenkins
Details
policy publisher contract tests Build #1014 succeeded on Jenkins
Details
whitehall contract tests Build #1060 succeeded on Jenkins
Details
@boffbowsh boffbowsh deleted the publication-subtype-examples branch May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.