Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document_collection schema #312

Merged
merged 6 commits into from May 25, 2016
Merged

Add document_collection schema #312

merged 6 commits into from May 25, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 18, 2016

Details:

  • Body is optional for collections
  • First public at is required like other editioned content
  • A document collection must have an ordered list of groups
    • Each group must have a title and an ordered list of documents, the group may have some body copy
  • Collections can be political
  • Collections can be withdrawn
  • Include tags – these are not really used except for emails, see #292 for why they weren't removed from other formats

Links:

  • Add documents GUID list, make this a required field
  • Whitehall marks "policy areas" as being required in the editor, but content schemas say this is "largely deprecated", so it has been intentionally left out. (Policy areas are included by base links)
  • Add topical events
  • Lead organisations are also required, we've changed the pattern for organisations to "organisations" in links and emphasised organisations in details – there isn't a pattern yet for which bits must be required
    to match current behaviour.

Include examples based on:
https://www.gov.uk/government/collections/national-driving-and-riding-standards
https://www.gov.uk/government/collections/financial-sanctions-regime-specific-consolidated-lists-and-releases

https://trello.com/c/PMeMQb5E/410-11-document-collection-migration-mvp-content-schema-examples-and-front-end-work

@fofr fofr force-pushed the mvp-document-collections branch from 24ccf5d to b740a82 May 18, 2016
@fofr fofr closed this May 20, 2016
@fofr
Copy link
Contributor Author

@fofr fofr commented May 20, 2016

Closing while adding more examples.

@fofr fofr reopened this May 24, 2016
@fofr fofr force-pushed the mvp-document-collections branch from 0e35832 to 524a7c2 May 25, 2016
fofr added 6 commits May 18, 2016
Details:
* Body is optional for collections
* First public at is required like other editioned content
* A document collection must have an ordered list of groups
* Each group must have a title and an ordered list of documents, the
group may have some body copy
* Collections can be political
* Collections can be withdrawn
* Include tags – these are not really used except for emails, see
#292 for why they
weren't removed from other formats

Links:
* Add documents GUID list, make this a required field
* Whitehall marks "policy areas" as being required in the editor, but
content schemas say this is "largely deprecated", so it has been
intentionally left out. (Policy areas are included by base links)
* Add topical events
* Lead organisations are also required, we've changed the pattern for
organisations to "organisations" in links and emphasised organisations
in details – there isn't a pattern yet for which bits must be required
to match current behaviour.
"document_collections" was included twice.

Interestingly this didn’t cause validations to fail.
Include features so they can be tested in the frontend
@fofr fofr force-pushed the mvp-document-collections branch from 524a7c2 to 60b76bd May 25, 2016
@boffbowsh boffbowsh merged commit e8dd971 into master May 25, 2016
17 checks passed
17 checks passed
Specialist frontend contract tests Build #814 succeeded on Jenkins
Details
Verify collections against content schemas Build #927 succeeded on Jenkins
Details
Verify collections-publisher against content schemas Build #914 succeeded on Jenkins
Details
Verify contacts-admin against content schemas Build #1048 succeeded on Jenkins
Details
Verify contacts-frontend against content schemas Build #584 succeeded on Jenkins
Details
Verify government-frontend against content schemas Build #1068 succeeded on Jenkins
Details
Verify hmrc-manuals-api against content schemas Build #732 succeeded on Jenkins
Details
Verify manuals-frontend against schema examples Build #908 succeeded on Jenkins
Details
Verify publisher against content schemas Build #965 succeeded on Jenkins
Details
Verify specialist-publisher against content schemas Build #1014 succeeded on Jenkins
Details
Verify specialist-publisher-rebuild against content schemas Build #139 succeeded on Jenkins
Details
Verify static components against schema examples Build #449 succeeded on Jenkins
Details
Verify travel-advice-publisher against content schemas Build #714 succeeded on Jenkins
Details
default Build #986 succeeded on Jenkins
Details
finder frontend contract tests Build #1065 succeeded on Jenkins
Details
policy publisher contract tests Build #1074 succeeded on Jenkins
Details
whitehall contract tests Build #1132 succeeded on Jenkins
Details
@boffbowsh boffbowsh deleted the mvp-document-collections branch May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.