Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add speeches schema and examples #468

Merged
merged 6 commits into from Dec 22, 2016
Merged

Add speeches schema and examples #468

merged 6 commits into from Dec 22, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 21, 2016

  • Add details and links schema for speeches
  • Add examples for draft transcript, transcript, written to parliament and authored article types of speech
  • Add example where speaker doesn't have a GOV.UK page (eg The Queen)

There are no known features missing from the schema.

Speaker images

The images are pulled from the profile of the assigned speaker. For now the frontend expects this to come from the image property in the details. It may in future make more sense for it to come via an image property in the links hash of the speaker – as that's the dependency.

Story: https://trello.com/c/TWsLTRzc/547-10-speech-migration-mvp-content-schema-examples-and-front-end-work

fofr added 6 commits Dec 21, 2016
Custom details properties:
* speech_type_explanation - for extra public facing help text that
explains the nature of the speech, eg “Transcript of the speech,
exactly as it was delivered”
* speaker_without_profile” - not all speakers have a profile page on
GOV.UK, so not all can appear in links.
* location - where the speech was given
* delivered_on - A required field, date speech or written statement
given
eg Her Majesty the Queen
@bevanloon
Copy link
Contributor

@bevanloon bevanloon commented Dec 22, 2016

LGTM 👍

@fofr fofr merged commit 1d58635 into master Dec 22, 2016
23 checks passed
23 checks passed
Verify business-support-finder against content schemas Build #414 succeeded on Jenkins
Details
Verify calendars against content schemas Build #415 succeeded on Jenkins
Details
Verify collections against content schemas Build #1498 succeeded on Jenkins
Details
Verify collections-publisher against content schemas Build #1486 succeeded on Jenkins
Details
Verify contacts-admin against content schemas Build #1618 succeeded on Jenkins
Details
Verify contacts-frontend against content schemas Build #1159 succeeded on Jenkins
Details
Verify content-tagger against content schemas Build #431 succeeded on Jenkins
Details
Verify finder-frontend against content schemas Build #1635 succeeded on Jenkins
Details
Verify government-frontend against content schemas Build #1644 succeeded on Jenkins
Details
Verify govuk_schemas_gem against content schemas Build #335 succeeded on Jenkins
Details
Verify hmrc-manuals-api against content schemas Build #1302 succeeded on Jenkins
Details
Verify licence-finder against content schemas Build #261 succeeded on Jenkins
Details
Verify manuals-frontend against schema examples Build #1478 succeeded on Jenkins
Details
Verify manuals-publisher against content schemas Build #1591 succeeded on Jenkins
Details
Verify multipage-frontend against content schemas Build #108 succeeded on Jenkins
Details
Verify policy-publisher against content schemas Build #1648 succeeded on Jenkins
Details
Verify publisher against content schemas Build #1554 succeeded on Jenkins
Details
Verify specialist-frontend against content schemas Build #1395 succeeded on Jenkins
Details
Verify specialist-publisher against content schemas Build #716 succeeded on Jenkins
Details
Verify static components against schema examples Build #1020 succeeded on Jenkins
Details
Verify travel-advice-publisher against content schemas Build #1314 succeeded on Jenkins
Details
Verify whitehall against content schemas Build #1707 succeeded on Jenkins
Details
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the speeches branch Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.