Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add corporate information page format #501

Merged
merged 8 commits into from Feb 6, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 30, 2017

Goes with alphagov/government-frontend#241

  • Add schema and examples for corporate information pages
  • Use "about page" as the canonical format document_type
  • Include examples for media and complaints document types, but not all types as further examples aren't necessary – apart from document_type (which isn't used during rendering), the examples would be identical.
  • Include a translated example for an organisation with a custom logo (Land Registry)

Notable features

  • Corporate information pages are always associated with a single organisation, the guid for the org is a required field in the details hash
  • Document types that are not "About" pages are children of about pages (they live at the URL /organisation-name/about/XXX

Notable omissions

Part of:
https://trello.com/c/8ySlDVSs/578-corp-info-migration-1-mvp-content-schema-examples-and-front-end-work

(At time of raising PR master was failing)

@fofr fofr changed the title Add corporate information pages format Add corporate information page format Jan 30, 2017
@Rosa-Fox
Copy link
Contributor

@Rosa-Fox Rosa-Fox commented Jan 30, 2017

Would be good to have another pair of eyes to check over, but I ran all of these examples locally on government-frontend comparing with the data in live and they looked fine to me.

},
"organisation": {
"description": "A single organisation that is the subject of this corporate information page",
"$ref": "#/definitions/guid"

This comment has been minimized.

@gpeng

gpeng Feb 2, 2017
Contributor

Should we be strict with this and add "maxItems": 1?

This comment has been minimized.

@fofr

fofr Feb 3, 2017
Author Contributor

It's not an array. It's a string that must be a GUID.

This comment has been minimized.

@gpeng

gpeng Feb 3, 2017
Contributor

Oh yes... So it is.

fofr added 8 commits Jan 26, 2017
Use about pages as canonical example
* One has long content with contents list, other is short with none
* Make “About” page direct parent for breadcrumbs, as that’s the parent
in the URL structure
Description’s are optional for this format
All corp info pages have a single organisation as their subject.

* Include a single GUID string as a required field
* Add field to examples
Also includes an example of a Land Registry page with a custom
organisation logo
@fofr fofr force-pushed the corporate-information-pages branch from 7659c6d to 726225a Feb 3, 2017
@fofr
Copy link
Contributor Author

@fofr fofr commented Feb 3, 2017

I've rebased against master and switched to using new definitions where required.

@gpeng
gpeng approved these changes Feb 3, 2017
@gpeng gpeng merged commit fcd4f63 into master Feb 6, 2017
14 checks passed
14 checks passed
Verify calendars against content schemas Build #575 succeeded on Jenkins
Details
Verify contacts-admin against content schemas Build #1778 succeeded on Jenkins
Details
Verify contacts-frontend against content schemas Build #1323 succeeded on Jenkins
Details
Verify government-frontend against content schemas Build #1805 succeeded on Jenkins
Details
Verify govuk_schemas_gem against content schemas Build #497 succeeded on Jenkins
Details
Verify hmrc-manuals-api against content schemas Build #1462 succeeded on Jenkins
Details
Verify licence-finder against content schemas Build #421 succeeded on Jenkins
Details
Verify manuals-frontend against schema examples Build #1638 succeeded on Jenkins
Details
Verify manuals-publisher against content schemas Build #1786 succeeded on Jenkins
Details
Verify multipage-frontend against content schemas Build #269 succeeded on Jenkins
Details
Verify specialist-frontend against content schemas Build #1555 succeeded on Jenkins
Details
Verify static components against schema examples Build #1180 succeeded on Jenkins
Details
Verify travel-advice-publisher against content schemas Build #1477 succeeded on Jenkins
Details
continuous-integration/jenkins/branch This commit looks good
Details
@gpeng gpeng deleted the corporate-information-pages branch Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants