Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat all authored JSON as part of the build #503

Merged
merged 3 commits into from Jan 30, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 30, 2017

Based on #448 (and #448 (comment))

  • Change is in b95c0d3
  • Treat all authored (hand crafted) JSON consistently
  • Use consistent line breaks and whitespace in details.json, links.json and examples not previously picked up (eg publisher v2 examples)

cc @tijmenb @nickcolley

fofr added 3 commits Jan 30, 2017
* Treat `details` and `links` the same way as examples
* Use consistent line breaks and whitespace for handcrafted JSON
This is noisy because it's the first time `rake reformat_authored_json`
is run.
Generated from running `bundle exec rake` after reformatting all JSON
in `/formats`
Copy link
Contributor

@tijmenb tijmenb left a comment

🚀

@tijmenb tijmenb merged commit bc835e9 into master Jan 30, 2017
15 checks passed
15 checks passed
@govuk-ci
Verify calendars against content schemas Build #544 succeeded on Jenkins
Details
@govuk-ci
Verify contacts-admin against content schemas Build #1747 succeeded on Jenkins
Details
@govuk-ci
Verify contacts-frontend against content schemas Build #1292 succeeded on Jenkins
Details
@govuk-ci
Verify government-frontend against content schemas Build #1774 succeeded on Jenkins
Details
@govuk-ci
Verify govuk_schemas_gem against content schemas Build #466 succeeded on Jenkins
Details
@govuk-ci
Verify hmrc-manuals-api against content schemas Build #1431 succeeded on Jenkins
Details
@govuk-ci
Verify licence-finder against content schemas Build #390 succeeded on Jenkins
Details
@govuk-ci
Verify manuals-frontend against schema examples Build #1607 succeeded on Jenkins
Details
@govuk-ci
Verify manuals-publisher against content schemas Build #1755 succeeded on Jenkins
Details
@govuk-ci
Verify multipage-frontend against content schemas Build #238 succeeded on Jenkins
Details
@govuk-ci
Verify publisher against content schemas Build #1684 succeeded on Jenkins
Details
@govuk-ci
Verify specialist-frontend against content schemas Build #1524 succeeded on Jenkins
Details
@govuk-ci
Verify static components against schema examples Build #1149 succeeded on Jenkins
Details
@govuk-ci
Verify travel-advice-publisher against content schemas Build #1443 succeeded on Jenkins
Details
@govuk-ci
continuous-integration/jenkins/branch This commit looks good
Details
@tijmenb tijmenb deleted the schema-differences branch Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants