Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Use definitions for shared properties in details #509
Follow up to #505
Features that share a name should share a definition. This:
Add definitions for shared features
Content schema technical debt found
* Features that share a name should share a definition * Avoids the risk that a format implements a feature that clashes with the name of another feature * Avoids the risk of implementing the same feature in a slightly different way in multiple places * Makes it harder to write `details.json` poorly * Run validation as part of default Rake task
tijmenb left a comment
This is fantastic
I've reviewed the individual commits and it all looks good.
The big increase in lines is expected because we ship the entire
Publisher is now being tested as part of
It'd be good to get a better understanding of the
h-lame left a comment
My comments are definitely not blockers, more for discussion. I'm not 100% sure about the things I've suggested we could merge, as I don't know if the titles and section_ids that cause differences between hmrc and govuk manuals have important semantic meanings even if they're ignored or treated as optional by the frontend rendering app.