Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove withdrawn notices from details #511

Merged
merged 2 commits into from Feb 8, 2017
Merged

Remove withdrawn notices from details #511

merged 2 commits into from Feb 8, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 3, 2017

Closes #487

Part of https://trello.com/c/AlivhTv8/591-remove-withdrawn-notice-from-details-in-schemas

Need to republish before merge:

  • There are 7,000 odd content items that have withdrawn notice in details and at top level
    {"case_study"=>46, "publication"=>7630, "detailed_guide"=>1}

Whitehall references to withdrawn notices in details that need updating:

 1) Failure:
PublishingApi::PublicationPresenterTest#test_a_withdrawn_publication_includes_details_of_the_archive_notice
JSON not valid against publication schema: ["The property '#/details' contains additional properties [\"withdrawn_notice\"] outside of the schema when none are allowed in schema

  1) Failure:
PublishingApi::CaseStudyPresenterTest#test_a_withdrawn_case_study_includes_details_of_the_archive_notice
JSON not valid against case_study schema: ["The property '#/details' contains additional properties [\"withdrawn_notice\"] outside of the schema when none are allowed in schema
fofr added 2 commits Feb 3, 2017
Remove notice from schema and examples rendered by government-frontend
@gpeng
gpeng approved these changes Feb 8, 2017
@fofr fofr changed the title [Do not merge] Remove withdrawn notices from details Remove withdrawn notices from details Feb 8, 2017
@fofr fofr merged commit 9341468 into master Feb 8, 2017
14 checks passed
14 checks passed
Verify calendars against content schemas Build #578 succeeded on Jenkins
Details
Verify contacts-admin against content schemas Build #1781 succeeded on Jenkins
Details
Verify contacts-frontend against content schemas Build #1326 succeeded on Jenkins
Details
Verify government-frontend against content schemas Build #1808 succeeded on Jenkins
Details
Verify govuk_schemas_gem against content schemas Build #500 succeeded on Jenkins
Details
Verify hmrc-manuals-api against content schemas Build #1465 succeeded on Jenkins
Details
Verify licence-finder against content schemas Build #424 succeeded on Jenkins
Details
Verify manuals-frontend against schema examples Build #1641 succeeded on Jenkins
Details
Verify manuals-publisher against content schemas Build #1789 succeeded on Jenkins
Details
Verify multipage-frontend against content schemas Build #272 succeeded on Jenkins
Details
Verify specialist-frontend against content schemas Build #1558 succeeded on Jenkins
Details
Verify static components against schema examples Build #1183 succeeded on Jenkins
Details
Verify travel-advice-publisher against content schemas Build #1480 succeeded on Jenkins
Details
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the remove-withdrawn-notices branch Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.