Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add corporate information groups to corporate information pages #522

Merged
merged 2 commits into from Feb 17, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 16, 2017

Part of:
https://trello.com/c/8syU3iNh/593-add-corporate-information-block-to-about-pages-corporate-information-pages-2

  • Create new definitions for internal links without GUIDs and external links
  • Create definition so that list of links can contain GUIDs, internal path without guid and external link
  • Create new grouped_lists_of_links definition, a flexible object type that can be later re-used by formats with custom groups
  • Modelled loosely on topic_groups
  • Include example on about page (groups are only used on this document type)
fofr added 2 commits Feb 13, 2017
* Create new definitions for internal links without GUIDs and external
links
* Create definition so that list of links can contain GUIDs, internal
path without guid and external link
* Create new grouped_lists_of_links definition, a flexible object type
that can be later re-used by formats with custom groups
* Modelled loosely on topic_groups
* Include example on about page (groups are only used on this document
type)
@fofr fofr force-pushed the corp-about-parts branch from 709e10c to cc2986a Feb 16, 2017
@gpeng
gpeng approved these changes Feb 16, 2017
@fofr fofr merged commit 2a0dd54 into master Feb 17, 2017
7 checks passed
7 checks passed
Verify calendars against content schemas Build #621 succeeded on Jenkins
Details
Verify government-frontend against content schemas Build #1850 succeeded on Jenkins
Details
Verify govuk_schemas_gem against content schemas Build #543 succeeded on Jenkins
Details
Verify multipage-frontend against content schemas Build #313 succeeded on Jenkins
Details
Verify travel-advice-publisher against content schemas Build #1525 succeeded on Jenkins
Details
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the corp-about-parts branch Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.