Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travel advice examples based on live content #525

Merged
merged 1 commit into from Feb 20, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 17, 2017

Ensure that examples are accurate before using them for tests in government-frontend.

I've also confirmed that a no-parts travel advice could feasibly published, although all countries currently have at least 5 parts.

Part of https://trello.com/c/L5Nd0AdH/137-3-render-travel-advice-in-government-frontend-l

Ensures that examples are accurate before using them for tests in
government-frontend.
@nickcolley nickcolley self-requested a review Feb 20, 2017
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Feb 20, 2017

I've reviewed this by running the dummy content store and checking these examples render correctly.

👍

@nickcolley nickcolley merged commit f87f087 into master Feb 20, 2017
7 checks passed
7 checks passed
Verify calendars against content schemas Build #634 succeeded on Jenkins
Details
Verify government-frontend against content schemas Build #1863 succeeded on Jenkins
Details
Verify govuk_schemas_gem against content schemas Build #556 succeeded on Jenkins
Details
Verify multipage-frontend against content schemas Build #326 succeeded on Jenkins
Details
Verify travel-advice-publisher against content schemas Build #1538 succeeded on Jenkins
Details
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@nickcolley nickcolley deleted the travel-advice-examples branch Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.