Deprecate "headings" on HTML publications #631
Merged
Conversation
Formerly a list of headings used to display a contents list, government-frontend no longer uses this data – instead it pulls headings out of the content and constructs a contents list that it can manipulate. This matches other contents lists in the app. See: alphagov/government-frontend#384
fofr
added a commit
to alphagov/whitehall
that referenced
this pull request
Jun 29, 2017
|
Closing while we investigate bugs with number formatting in new contents lists. |
|
This is good to review now. |
nickcolley
merged commit 9d8a912
into
master
19 checks passed
19 checks passed
continuous-integration/jenkins/collections-publisher
Downstream collections-publisher job succeeded on Jenkins
Details
continuous-integration/jenkins/content-store
Downstream content-store job succeeded on Jenkins
Details
continuous-integration/jenkins/content-tagger
Downstream content-tagger job succeeded on Jenkins
Details
continuous-integration/jenkins/email-alert-frontend
Downstream email-alert-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/email-alert-service
Downstream email-alert-service job succeeded on Jenkins
Details
continuous-integration/jenkins/finder-frontend
Downstream finder-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/government-frontend
Downstream government-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/info-frontend
Downstream info-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/manuals-frontend
Downstream manuals-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/manuals-publisher
Downstream manuals-publisher job succeeded on Jenkins
Details
continuous-integration/jenkins/policy-publisher
Downstream policy-publisher job succeeded on Jenkins
Details
continuous-integration/jenkins/specialist-publisher
Downstream specialist-publisher job succeeded on Jenkins
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Formerly a list of headings used to display a contents list, government-frontend no longer uses this data – instead it pulls headings out of the content and constructs a contents list that it can manipulate. This matches other contents lists in the app.
See: alphagov/government-frontend#384
@nickcolley @andysellick