Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate "headings" on HTML publications #631

Merged
merged 3 commits into from Jul 10, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 29, 2017

Formerly a list of headings used to display a contents list, government-frontend no longer uses this data – instead it pulls headings out of the content and constructs a contents list that it can manipulate. This matches other contents lists in the app.

See: alphagov/government-frontend#384

@nickcolley @andysellick

fofr added 3 commits Jun 29, 2017
Formerly a list of headings used to display a contents list,
government-frontend no longer uses this data – instead it pulls
headings out of the content and constructs a contents list that it can
manipulate. This matches other contents lists in the app.

See: alphagov/government-frontend#384
fofr added a commit to alphagov/whitehall that referenced this pull request Jun 29, 2017
@fofr
Copy link
Contributor Author

@fofr fofr commented Jun 29, 2017

Closing while we investigate bugs with number formatting in new contents lists.

@fofr fofr closed this Jun 29, 2017
@fofr fofr reopened this Jul 7, 2017
@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 10, 2017

This is good to review now.

@nickcolley nickcolley merged commit 9d8a912 into master Jul 10, 2017
19 checks passed
19 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/calculators Downstream calculators job succeeded on Jenkins
Details
continuous-integration/jenkins/calendars Downstream calendars job succeeded on Jenkins
Details
continuous-integration/jenkins/collections Downstream collections job succeeded on Jenkins
Details
continuous-integration/jenkins/collections-publisher Downstream collections-publisher job succeeded on Jenkins
Details
continuous-integration/jenkins/content-store Downstream content-store job succeeded on Jenkins
Details
continuous-integration/jenkins/content-tagger Downstream content-tagger job succeeded on Jenkins
Details
continuous-integration/jenkins/email-alert-frontend Downstream email-alert-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/email-alert-service Downstream email-alert-service job succeeded on Jenkins
Details
continuous-integration/jenkins/finder-frontend Downstream finder-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/frontend Downstream frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/government-frontend Downstream government-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/info-frontend Downstream info-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/manuals-frontend Downstream manuals-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/manuals-publisher Downstream manuals-publisher job succeeded on Jenkins
Details
continuous-integration/jenkins/policy-publisher Downstream policy-publisher job succeeded on Jenkins
Details
continuous-integration/jenkins/publisher Downstream publisher job succeeded on Jenkins
Details
continuous-integration/jenkins/specialist-publisher Downstream specialist-publisher job succeeded on Jenkins
Details
continuous-integration/jenkins/static Downstream static job succeeded on Jenkins
Details
@nickcolley nickcolley deleted the loosen-html-pub-req branch Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.