Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove appear_in_find_eu_exit_guidance_business_finder #961

Merged
merged 1 commit into from Feb 12, 2020

Conversation

@huwd
Copy link
Contributor

huwd commented Feb 12, 2020

Trello: https://trello.com/c/qBM5QLID/482-business-finder-tech-debt

appear_in_find_eu_exit_guidance_business_finder is old technical debt surfaced as part of removing the business finder.

It looks like the appear_in_find_eu_exit_guidance_business_finder checkbox approach was >replaced the facet_groups approach:

alphagov/finder-frontend@6f484a6
https://github.com/alphagov/search-api/pull/1535/files

The finder content schema needs to have appear_in_find_eu_exit_guidance_business_finder removed too: https://github.com/alphagov/govuk-content-schemas/blob/master/formats/shared/definitions/finder.jsonnet#L51.

Removes appear_in_find_eu_exit_guidance_business_finder from:

  • Finder Frontend schema json
  • Finder Notification schema json
  • Finder Publisher v2 schema json
  • Finder shared defintions jsonnet
@huwd huwd requested review from vanitabarrett, koetsier and laurentqro Feb 12, 2020
@huwd huwd changed the title Remove appear_in_find_eu_exit_guidance_business_finder [WIP] Remove appear_in_find_eu_exit_guidance_business_finder Feb 12, 2020
@huwd

This comment has been minimized.

Copy link
Contributor Author

huwd commented Feb 12, 2020

Humm, hold off reviewing 1 sec, test failures.

@huwd huwd changed the title [WIP] Remove appear_in_find_eu_exit_guidance_business_finder Remove appear_in_find_eu_exit_guidance_business_finder Feb 12, 2020
@huwd huwd merged commit 4fbde34 into master Feb 12, 2020
31 checks passed
31 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/calculators Downstream calculators job succeeded on Jenkins
Details
continuous-integration/jenkins/calendars Downstream calendars job succeeded on Jenkins
Details
continuous-integration/jenkins/collections Downstream collections job succeeded on Jenkins
Details
continuous-integration/jenkins/collections-publisher Downstream collections-publisher job succeeded on Jenkins
Details
continuous-integration/jenkins/contacts Downstream contacts job succeeded on Jenkins
Details
continuous-integration/jenkins/content-data-api Downstream content-data-api job succeeded on Jenkins
Details
continuous-integration/jenkins/content-store Downstream content-store job succeeded on Jenkins
Details
continuous-integration/jenkins/content-tagger Downstream content-tagger job succeeded on Jenkins
Details
continuous-integration/jenkins/email-alert-frontend Downstream email-alert-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/email-alert-service Downstream email-alert-service job succeeded on Jenkins
Details
continuous-integration/jenkins/feedback Downstream feedback job succeeded on Jenkins
Details
continuous-integration/jenkins/finder-frontend Downstream finder-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/frontend Downstream frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/government-frontend Downstream government-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/hmrc-manuals-api Downstream hmrc-manuals-api job succeeded on Jenkins
Details
continuous-integration/jenkins/info-frontend Downstream info-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/licencefinder Downstream licencefinder job succeeded on Jenkins
Details
continuous-integration/jenkins/manuals-frontend Downstream manuals-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/manuals-publisher Downstream manuals-publisher job succeeded on Jenkins
Details
continuous-integration/jenkins/publisher Downstream publisher job succeeded on Jenkins
Details
continuous-integration/jenkins/publishing-api Downstream publishing-api job succeeded on Jenkins
Details
continuous-integration/jenkins/search-admin Downstream search-admin job succeeded on Jenkins
Details
continuous-integration/jenkins/search-api Downstream search-api job succeeded on Jenkins
Details
continuous-integration/jenkins/service-manual-frontend Downstream service-manual-frontend job succeeded on Jenkins
Details
continuous-integration/jenkins/service-manual-publisher Downstream service-manual-publisher job succeeded on Jenkins
Details
continuous-integration/jenkins/short-url-manager Downstream short-url-manager job succeeded on Jenkins
Details
continuous-integration/jenkins/smartanswers Downstream smartanswers job succeeded on Jenkins
Details
continuous-integration/jenkins/specialist-publisher Downstream specialist-publisher job succeeded on Jenkins
Details
continuous-integration/jenkins/static Downstream static job succeeded on Jenkins
Details
continuous-integration/jenkins/whitehall Downstream whitehall job succeeded on Jenkins
Details
@huwd huwd deleted the remove_appear_in_find_eu_exit_guidance_business_finder branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.