Skip to content
This repository has been archived by the owner on Nov 27, 2020. It is now read-only.

馃毀 Change Dynimoid logging level to :info #118

Closed
wants to merge 1 commit into from

Conversation

huwd
Copy link
Member

@huwd huwd commented Mar 25, 2020

Trello: https://trello.com/c/99xm7mlq/86-ensure-sensitive-data-doesnt-go-to-logit-splunk

DRAFT PENDING TEST ON STAGING
Replaced by: #168

Test

  • Get this on staging
  • Noodle around
    • Normal browse behaviour
    • Cause an error
    • Submit a stand-in for PII
    • Cause validation error
  • Logs should have No PII
  • Logs should have validation errors
  • Logs should have errors
  • check the logs since deploy

What

tweak the logging levels in production to prevent PII getting in, but ensure we still get useful logs on validation attempts

Why

Keep cyber happy, keep debugging devs happy.

@huwd huwd requested a review from richardTowers March 25, 2020 11:44
@bevanloon bevanloon temporarily deployed to coronavirus-change-log-ukllkf8 March 25, 2020 11:44 Inactive
Copy link
Contributor

@bilbof bilbof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 馃憤

@huwd
Copy link
Member Author

huwd commented Mar 25, 2020

Made a paralell one for the vulnerable people form:
Sean noted - alphagov/govuk-coronavirus-vulnerable-people-form#172

Do turns out logs can have PII in them cry - We ended up having reduce the log level #141. I think Dynamoid is sharing the default Rails logger - so we are suppressing all Rails log with setting. Maybe need to make a separate logger? Think we need info level for rails as validation errors probably aren't "application errors".

@huwd huwd marked this pull request as ready for review March 30, 2020 09:32
@huwd huwd changed the title Change Dynimoid logging level to :info [Do not merge] Change Dynimoid logging level to :info Mar 30, 2020
@huwd huwd changed the title [Do not merge] Change Dynimoid logging level to :info 馃毀 Change Dynimoid logging level to :info Mar 30, 2020
@huwd huwd added the do not merge Please, don't label Mar 30, 2020
@huwd
Copy link
Member Author

huwd commented Mar 30, 2020

This should go on hold or be closed depending on the outcome of this PR:
alphagov/govuk-coronavirus-vulnerable-people-form#205

I suggest we get the response right there and then mirror it from the vulnerable people app to this one

@huwd huwd closed this Apr 1, 2020
@huwd huwd deleted the change-log-levels branch April 8, 2020 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do not merge Please, don't
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants