Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self host favicon #152

Merged
merged 1 commit into from Mar 23, 2020
Merged

Self host favicon #152

merged 1 commit into from Mar 23, 2020

Conversation

@nickcolley
Copy link
Contributor

nickcolley commented Mar 23, 2020

Prevents the need to open a request to another domain.

Closes #151

Can someone double check that I have not messed this up, I'm not super hot on the asset pipeline, thanks :)

Prevents the need to open a request to another domain.

Closes #151
@nickcolley nickcolley requested a review from Nooshu Mar 23, 2020
@huwd
huwd approved these changes Mar 23, 2020
@nickcolley nickcolley merged commit 33abecf into master Mar 23, 2020
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@nickcolley nickcolley deleted the self-host-favicon branch Mar 23, 2020
@injms

This comment has been minimized.

Copy link
Member

injms commented Mar 23, 2020

Is the favicon part of this pull request? It's appearing as 0 bytes.

@nickcolley

This comment has been minimized.

Copy link
Contributor Author

nickcolley commented Mar 23, 2020

@injms will double check and make sure on staging too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.