New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase banner #57

Open
govuk-design-system opened this Issue Jan 12, 2018 · 5 comments

Comments

5 participants
@govuk-design-system
Copy link
Collaborator

govuk-design-system commented Jan 12, 2018

Use this issue to discuss this component in the GOV.UK Design System.

@govuk-design-system govuk-design-system created this issue from a note in GOV.UK Design System Community Backlog (In progress) Jan 12, 2018

@govuk-design-system govuk-design-system moved this from In progress to Published in GOV.UK Design System Community Backlog Jan 12, 2018

@timpaul

This comment has been minimized.

Copy link
Contributor

timpaul commented Feb 15, 2018

There's some evidence here from the GOV.UK Notify team that the beta banner can cause confusion and even put some people off using their service: alphagov/notifications-admin#1838

@36degrees

This comment has been minimized.

Copy link

36degrees commented Feb 15, 2018

Worth noting that they weren't using the beta banner, just the beta tag – as per the product page example.

A traditional beta banner might have been fine. It possibly is evidence that that the tag by itself isn't working, though.

@timpaul timpaul added the component label May 21, 2018

@jbuller

This comment has been minimized.

Copy link

jbuller commented Feb 8, 2019

It would be useful to have clarity on whether the phase banner (and breadcrumb)s should be inside the main element or not. (I'd say outside)
The Start page pattern on the Design System has it above


However for example https://www.gov.uk/service-manual/helping-people-to-use-your-service/making-your-service-accessible-an-introduction has it inside the main element,
This means the Skip to content link only cuts out about half the points of keyboard focus it would otherwise.

@dashouse

This comment has been minimized.

Copy link

dashouse commented Feb 11, 2019

@jbuller @stevenaproctor Hi, you'll find this implemented in many different ways across GOV.UK sites as they were all made at different times. If you're using the GOV.UK Design System / GOV.UK Frontend then this page on the design system clarifies the structure of the page we intend people to use https://design-system.service.gov.uk/styles/layout/#page-wrappers

@jbuller

This comment has been minimized.

Copy link

jbuller commented Feb 11, 2019

Thanks for the pointer.
I'd say it should be clearer on the phase banner page, or link to where it is clarified.
I didn't even find the page you highlighted when I was searching.
Actually, only the 'Customised page template' section of next page has the phase banner html in the larger context, above main element https://design-system.service.gov.uk/styles/page-template/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment