New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag #62

Open
govuk-design-system opened this Issue Jan 12, 2018 · 5 comments

Comments

6 participants
@govuk-design-system
Copy link
Collaborator

govuk-design-system commented Jan 12, 2018

Use this issue to discuss this component in the GOV.UK Design System.

@abbott567

This comment has been minimized.

Copy link

abbott567 commented Jun 12, 2018

We have these in our service to show the status of a claim. However, we have modified the background colour so agents can quickly identify allowed claims vs disallowed claims etc. Is there any scope to add modifier classes for this?

eg: .govuk-c-tag .govuk-c-tag--danger

image

@nickcolley

This comment has been minimized.

Copy link
Contributor

nickcolley commented Jun 12, 2018

@abbott567 makes sense! For now when you're extending the classes make sure to change the namespace to something that will not conflict in the future: .app-tag--danger etc

@danboscaro

This comment was marked as resolved.

Copy link

danboscaro commented Aug 10, 2018

Just a purely visual comment...
The top/bottom padding on the tag is uneven and makes it look a bit wonky
Can I suggest changing the top padding from 5px to 3px?

@nickcolley

This comment was marked as resolved.

Copy link
Contributor

nickcolley commented Aug 10, 2018

Hey Dan :)

This is because the custom font we use sits slightly higher than other common fonts, we were hoping we could release a new version of GOV.UK Frontend with vertical spacing that is more common.

In the meantime I think we could add some adjustments, I'll add a fix for this.

@mrkwrght

This comment has been minimized.

Copy link

mrkwrght commented Dec 10, 2018

we have modified our status tags on the tasklist to be easy to read by mading them lower case and upping the font size to 19px like the rest of the text.

we have also created a 'In Progress' tag because it wasn't clear to our users which tasks had been started when navigating back to the tasklist.

feedback would be great!

screenshot 2018-11-28 at 10 25 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment