New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating sass-exports npm module breaks lib/colours.js #731

Open
aliuk2012 opened this Issue Jan 25, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@aliuk2012
Copy link
Contributor

aliuk2012 commented Jan 25, 2019

First timers only

This issue is reserved for people who have never contributed to the GOV.UK Design System before, please only pick this up if you're a new contributor.

Description

After updating sass-exports (npm install sass-exports@1.0.3), when you try run npm test or npm start the following error appears:

TypeError: Cannot read property 'reduce' of undefined

paletteMap is returning undefined and therefore on this line reduce method fails.

If you remove .mapValue (https://github.com/alphagov/govuk-design-system/blob/master/lib/colours.js#L25), paletteMap returns a value but not in the correct format.

Step by Step

1. Claim this issue

Comment below to let other people know that you're working on this issue.

2. Fork the repository

3. Edit colours.js file

palette should set to

{
  "black":"#0b0c0c",
  "blue":"#005ea5",
  "bright-purple":"#912b88",
  "bright-red":"#df3034",
  "brown":"#b58840",
  "green":"#006435",
  "grey-1":"#6f777b",
  "grey-2":"#bfc1c3",
  "grey-3":"#dee0e2",
  "grey-4":"#f8f8f8",
  "light-blue":"#2b8cc4",
  "light-green":"#85994b",
  "light-pink":"#f499be",
  "light-purple":"#6f72af",
  "orange":"#f47738",
  "pink":"#d53880",
  "purple":"#2e358b",
  "red":"#b10e1e",
  "turquoise":"#28a197",
  "white":"#ffffff",
  "yellow":"#ffbf47"
}

4. Create a Pull Request

5. Done

We'll review the Pull Request and let you know if any changes are needed.

Questions

If you’ve got a question, you can comment in this issue or email the Design System team on govuk-design-system-support@digital.cabinet-office.gov.uk

@fearn2001

This comment has been minimized.

Copy link

fearn2001 commented Jan 26, 2019

I'll claim this issue.

@fearn2001

This comment has been minimized.

Copy link

fearn2001 commented Jan 26, 2019

I think I've done it but I can't create a pull request.

@aliuk2012

This comment has been minimized.

Copy link
Contributor Author

aliuk2012 commented Jan 27, 2019

Hi @fearn2001,

Thank you for claiming this issue and taking the time to work on it.

Could you confirm that you have forked the repository as mentioned step 2?

Once you have it working locally you will need to push up your changes to GitHub and then from this repository you should be able to create a pull request.

Some tutorials covering Creating pull requests.

@sog01

This comment has been minimized.

Copy link

sog01 commented Jan 28, 2019

Can I work on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment