Explain why start buttons are output as HTML links, not buttons #1372
Conversation
|
You can preview this change here: Built with commit 46a1cc0 https://deploy-preview-1372--govuk-design-system-preview.netlify.app |
|
Hmm, as per Ed's comment here and his issue here, we could go ever further and provide an explicit example of a link styled as a button. |
Based on feedback from Joe L in PR
timpaul
requested review from
trang-erskine and
joelanman
and removed request for
StephenGill and
joelanman
There was a problem hiding this comment.
Nikki suggested splitting it into 2 sentences. The 2nd option removes "are rendered" which is my preferred option.
"Start buttons are rendered as links rather than inputs. This is because your users are not submitting any data."
"Start buttons are links rather than inputs. This is because your user are not submitting any data."
|
I realised after the review that the wording is incorrect - default buttons use the button HTML element, not the input one. In the end I chose to be explicit and name the actual HTML tags involved, to avoid the potential confusion of saying "Start buttons are links not buttons". |
timpaul
changed the title
To prevent them being interpreted as invalid HTML code
Reduce repetition and use a single sentence instead of two.
In response to this query in the backlog: alphagov/govuk-design-system-backlog#34 (comment)