Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement periodic review system #102

Merged
merged 1 commit into from Apr 12, 2017
Merged

Implement periodic review system #102

merged 1 commit into from Apr 12, 2017

Conversation

@tijmenb
Copy link
Contributor

@tijmenb tijmenb commented Apr 10, 2017

This adds a system to keep track of pages that need to be updated.

  • Every page can have a expire_by and owner_slack attribute
  • When its set we will show this information at the bottom of the page
  • A week before the page is set to expire, the page title appears under "Pages to be reviewed soon" on the manual homepage
  • After the page is expired the page with display a warning on the top of the page indicating that it may no longer be accurate
  • The expired page is also listed under "Expired pages" on the manuals page

screen shot 2017-04-12 at 10 05 19
screen shot 2017-04-12 at 10 05 24
screen shot 2017-04-12 at 10 06 01

https://trello.com/c/ZUd0ITTZ

@tijmenb tijmenb temporarily deployed to govuk-tech-docs-pr-102 Apr 10, 2017 Inactive
@tijmenb tijmenb force-pushed the automated-reviews branch from 503b340 to ba357ca Apr 10, 2017
@tijmenb tijmenb temporarily deployed to govuk-tech-docs-pr-102 Apr 10, 2017 Inactive
@tijmenb tijmenb force-pushed the automated-reviews branch from ba357ca to 1724352 Apr 10, 2017
@tijmenb tijmenb temporarily deployed to govuk-tech-docs-pr-102 Apr 10, 2017 Inactive
@tijmenb tijmenb changed the title Implement periodic review system [WIP] Implement periodic review system Apr 11, 2017
@tijmenb tijmenb force-pushed the automated-reviews branch from 1724352 to 05fa029 Apr 12, 2017
@tijmenb tijmenb temporarily deployed to govuk-tech-docs-pr-102 Apr 12, 2017 Inactive
@tijmenb tijmenb changed the title [WIP] Implement periodic review system Implement periodic review system Apr 12, 2017
@tijmenb tijmenb force-pushed the automated-reviews branch from 05fa029 to ec91a59 Apr 12, 2017
@tijmenb tijmenb temporarily deployed to govuk-tech-docs-pr-102 Apr 12, 2017 Inactive

<p>Everyone on GOV.UK is responsible for keeping the opsmanual up to date. To ensure
this, every page should have a named owner. This person will be pinged whenever a page
threatens to go out of date.</p>
Copy link
Contributor

@whoojemaflip whoojemaflip Apr 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true? It sounds faintly menacing!

Loading

Copy link
Contributor Author

@tijmenb tijmenb Apr 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, we haven't got that yet. Removed the sentence until the bot exists.

Loading

@@ -3,6 +3,8 @@ title: Run an A/B test
parent: /manual.html
layout: manual_layout
section: Tools
owner: Tijmen
Copy link
Contributor

@whoojemaflip whoojemaflip Apr 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be your slack username?

Loading

Copy link
Contributor Author

@tijmenb tijmenb Apr 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, updated.

Loading

@whoojemaflip
Copy link
Contributor

@whoojemaflip whoojemaflip commented Apr 12, 2017

I feel this should link to a page in the dev manual explaining the review process in more detail...

Loading

@tijmenb tijmenb force-pushed the automated-reviews branch from ec91a59 to 4c3040d Apr 12, 2017
@tijmenb tijmenb temporarily deployed to govuk-tech-docs-pr-102 Apr 12, 2017 Inactive
@tijmenb
Copy link
Contributor Author

@tijmenb tijmenb commented Apr 12, 2017

@whoojemaflip the review doc is currently being drafted:
https://docs.google.com/document/d/1DfFZWnUHje4SSKSMa_wWRQdwWdA0akT6iUeCHe6Vvn4/edit

We'll definitely add it once finished.

Loading

This adds a system to keep track of pages that need to be updated.

- Every page can have a `expire_by` and `owner_slack` attribute
- When its set we will show this information at the bottom of the page
- A week before the page is set to expire, the page title appears under
"Pages to be reviewed soon" on the manual homepage
- After the page is expired the page with display a warning on the top
of the page indicating that it may no longer be accurate
- The page is also listed under "Expired pages"

https://trello.com/c/ZUd0ITTZ
@tijmenb tijmenb force-pushed the automated-reviews branch from 75901a7 to 9ab9c61 Apr 12, 2017
@tijmenb tijmenb had a problem deploying to govuk-tech-docs-pr-102 Apr 12, 2017 Failure
Copy link
Contributor

@whoojemaflip whoojemaflip left a comment

🎉

Loading

@tijmenb tijmenb merged commit 0116028 into master Apr 12, 2017
1 check passed
Loading
@tijmenb tijmenb deleted the automated-reviews branch Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants