Implement periodic review system #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tijmenb
force-pushed
the
automated-reviews
branch
from
503b340
to
ba357ca
Compare
tijmenb
force-pushed
the
automated-reviews
branch
from
ba357ca
to
1724352
Compare
tijmenb
changed the title
tijmenb
force-pushed
the
automated-reviews
branch
from
1724352
to
05fa029
Compare
tijmenb
changed the title
tijmenb
force-pushed
the
automated-reviews
branch
from
05fa029
to
ec91a59
Compare
source/manual.html.erb
Outdated
|
|
||
| <p>Everyone on GOV.UK is responsible for keeping the opsmanual up to date. To ensure | ||
| this, every page should have a named owner. This person will be pinged whenever a page | ||
| threatens to go out of date.</p> |
There was a problem hiding this comment.
Is this true? It sounds faintly menacing!
There was a problem hiding this comment.
Good point, we haven't got that yet. Removed the sentence until the bot exists.
source/manual/ab-testing.html.md
Outdated
| @@ -3,6 +3,8 @@ title: Run an A/B test | |||
| parent: /manual.html | |||
| layout: manual_layout | |||
| section: Tools | |||
| owner: Tijmen | |||
There was a problem hiding this comment.
does this need to be your slack username?
There was a problem hiding this comment.
Good idea, updated.
|
I feel this should link to a page in the dev manual explaining the review process in more detail... |
tijmenb
force-pushed
the
automated-reviews
branch
from
ec91a59
to
4c3040d
Compare
|
@whoojemaflip the review doc is currently being drafted: We'll definitely add it once finished. |
This adds a system to keep track of pages that need to be updated. - Every page can have a `expire_by` and `owner_slack` attribute - When its set we will show this information at the bottom of the page - A week before the page is set to expire, the page title appears under "Pages to be reviewed soon" on the manual homepage - After the page is expired the page with display a warning on the top of the page indicating that it may no longer be accurate - The page is also listed under "Expired pages" https://trello.com/c/ZUd0ITTZ
tijmenb
force-pushed
the
automated-reviews
branch
from
75901a7
to
9ab9c61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a system to keep track of pages that need to be updated.
expire_byandowner_slackattributehttps://trello.com/c/ZUd0ITTZ