Fix a couple of issues with the Intro to Docker #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issyl0
suggested changes
Nov 6, 2019
| @@ -315,7 +315,7 @@ $mac docker run -it -v content-publisher-postgres:/var/lib/postgresql/data --net | |||
| $mac docker run -it -v $PWD:/app -v content-publisher-bundle:/usr/local/bundle --privileged --network content-publisher-network -e TEST_DATABASE_URL=postgresql://postgres@postgres/content-publisher-test -e DATABASE_URL=postgresql://postgres@postgres/content-publisher content-publisher-demo bash | |||
| ``` | |||
|
|
|||
| This is a lot to run in one command! Luckily, other people have had this exact problem, and came up with [docker-compose]. With 'compose', we can convert our long commands into some YAML configuration. | |||
| This is a lot to run in one command! Luckily, other people have had this exact problem, and came up with [docker-compose]. With 'compose', we can convert our long commands into some YAML configuration file called `docker-compose.yml`. | |||
There was a problem hiding this comment.
Suggested change
| This is a lot to run in one command! Luckily, other people have had this exact problem, and came up with [docker-compose]. With 'compose', we can convert our long commands into some YAML configuration file called `docker-compose.yml`. | |
| This is a lot to run in one command! Luckily, other people have had this exact problem, and came up with [docker-compose]. With 'compose', we can convert our long commands into a YAML configuration file called `docker-compose.yml`. |
There was a problem hiding this comment.
Oops - title should have been "...and introduce another one!". Fixed.
benthorner
force-pushed
the
fix-docker-intro-error
branch
from
d7c897b
to
dfa4250
Compare
huwd
approved these changes
Nov 6, 2019
issyl0
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.