Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of issues with the Intro to Docker #2106

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@benthorner
Copy link
Contributor

benthorner commented Nov 6, 2019

No description provided.

@@ -315,7 +315,7 @@ $mac docker run -it -v content-publisher-postgres:/var/lib/postgresql/data --net
$mac docker run -it -v $PWD:/app -v content-publisher-bundle:/usr/local/bundle --privileged --network content-publisher-network -e TEST_DATABASE_URL=postgresql://postgres@postgres/content-publisher-test -e DATABASE_URL=postgresql://postgres@postgres/content-publisher content-publisher-demo bash
```
This is a lot to run in one command! Luckily, other people have had this exact problem, and came up with [docker-compose]. With 'compose', we can convert our long commands into some YAML configuration.
This is a lot to run in one command! Luckily, other people have had this exact problem, and came up with [docker-compose]. With 'compose', we can convert our long commands into some YAML configuration file called `docker-compose.yml`.

This comment has been minimized.

Copy link
@issyl0

issyl0 Nov 6, 2019

Member
Suggested change
This is a lot to run in one command! Luckily, other people have had this exact problem, and came up with [docker-compose]. With 'compose', we can convert our long commands into some YAML configuration file called `docker-compose.yml`.
This is a lot to run in one command! Luckily, other people have had this exact problem, and came up with [docker-compose]. With 'compose', we can convert our long commands into a YAML configuration file called `docker-compose.yml`.

This comment has been minimized.

Copy link
@benthorner

benthorner Nov 6, 2019

Author Contributor

Oops - title should have been "...and introduce another one!". Fixed.

@benthorner benthorner force-pushed the fix-docker-intro-error branch from d7c897b to dfa4250 Nov 6, 2019
@bevanloon bevanloon requested a deployment to govuk-developer-docs-f-pr-2106 Nov 6, 2019 Abandoned
@huwd
huwd approved these changes Nov 6, 2019
@issyl0
issyl0 approved these changes Nov 6, 2019
@benthorner benthorner merged commit 0f69062 into master Nov 6, 2019
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@benthorner benthorner deleted the fix-docker-intro-error branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.