Review change of government docs #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issyl0
suggested changes
Dec 5, 2019
source/manual/howto-change-a-government-following-an-election.html.md
Outdated
Show resolved
Hide resolved
source/manual/howto-change-a-government-following-an-election.html.md
Outdated
Show resolved
Hide resolved
source/manual/howto-change-a-government-following-an-election.html.md
Outdated
Show resolved
Hide resolved
bevanloon
reviewed
Dec 5, 2019
| [PoliticalContentIdentifier][]. The `political` flag on an `Edition` | ||
| can also be set manually. | ||
| [PoliticalContentIdentifier][]. The `political` flag on an `Edition` can also | ||
| be set manually. | ||
|
|
||
| [PoliticalContentIdentifier]: https://github.com/alphagov/whitehall/blob/master/lib/political_content_identifier.rb |
There was a problem hiding this comment.
We also need to:
Re-index political content in search
After the government has been closed, we need to re-index content in search. There is a rake task to do this.
There was a problem hiding this comment.
Oh yes... I've added a section about that.
thomasleese
force-pushed
the
review-history-mode-docs
branch
from
8da29c2
to
0d41473
Compare
thomasleese
force-pushed
the
review-history-mode-docs
branch
from
0d41473
to
6907bec
Compare
issyl0
approved these changes
Dec 5, 2019
bevanloon
reviewed
Dec 5, 2019
source/manual/howto-change-a-government-following-an-election.html.md
Outdated
Show resolved
Hide resolved
bevanloon
reviewed
Dec 5, 2019
We no longer need to run a manual Rake task to republish all content since Whitehall links content to governments and we can let the Publishing API do the dependency resolution.
This allows the page to be found when searching for history mode in the developer docs.
thomasleese
force-pushed
the
review-history-mode-docs
branch
from
6907bec
to
c3fb838
Compare
bevanloon
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the documentation on change of governments are up to date, especially with our recent changes around representing governments in the Publishing API.
Trello Card