Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for running frontend apps to include govuk-docker #2180

Closed
wants to merge 1 commit into from

Conversation

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Dec 18, 2019

@karlbaker02 karlbaker02 temporarily deployed to govuk-developer-docs-f-pr-2180 Dec 18, 2019 Inactive
@vanitabarrett vanitabarrett force-pushed the update-frontend-local-dev-docs branch from efb7363 to 1e836b7 Dec 18, 2019
@karlbaker02 karlbaker02 temporarily deployed to govuk-developer-docs-f-pr-2180 Dec 18, 2019 Inactive
@vanitabarrett vanitabarrett force-pushed the update-frontend-local-dev-docs branch from 1e836b7 to 9894ebc Dec 18, 2019
@vanitabarrett vanitabarrett changed the title Tidy up running frontend app docs Update docs for running frontend apps to include govuk-docker Dec 18, 2019
@vanitabarrett vanitabarrett marked this pull request as ready for review Dec 18, 2019
@vanitabarrett vanitabarrett requested a review from chao-xian Dec 18, 2019
@maxgds
maxgds approved these changes Jan 9, 2020
Copy link
Contributor

maxgds left a comment

Looks good - very useful update.

Copy link
Member

issyl0 left a comment

Nothing we do is simple. 😉


Make changes to the Gemfile of the frontend app you're working on as per [changes to govuk_publishing_components above](#running-a-frontend-app-against-changes-in-govuk_publishing_components), then set in `development.rb`:
If you are simply making changes to a frontend app and nothing else, you can view these changes by running the following:

This comment has been minimized.

Copy link
@issyl0

issyl0 Jan 9, 2020

Member
Suggested change
If you are simply making changes to a frontend app and nothing else, you can view these changes by running the following:
If you are making changes to a frontend app and nothing else, you can view these changes by running the following:

## Running just a frontend app against live data
## Using startup scripts
If you are simply making changes to a frontend app and nothing else, you can view these changes by running the application `./startup.sh` script:

This comment has been minimized.

Copy link
@issyl0

issyl0 Jan 9, 2020

Member
Suggested change
If you are simply making changes to a frontend app and nothing else, you can view these changes by running the application `./startup.sh` script:
If you are making changes to a frontend app and nothing else, you can view these changes by running the application `./startup.sh` script:
@vanitabarrett

This comment has been minimized.

Copy link
Contributor Author

vanitabarrett commented Jan 9, 2020

Thanks both! Kelvin has actually added some govuk-docker steps already, so I'm going to close this PR and open a new one based off his changes.

@vanitabarrett

This comment has been minimized.

Copy link
Contributor Author

vanitabarrett commented Jan 9, 2020

Superseded by #2210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.