Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Re-create an AWS mongo instance #2219

Merged
merged 1 commit into from Jan 15, 2020
Merged

Review Re-create an AWS mongo instance #2219

merged 1 commit into from Jan 15, 2020

Conversation

@camdesgov
Copy link
Contributor

camdesgov commented Jan 10, 2020

Fix typo.

Fix numbering (markdown automatic numbering doesn't
work correctly after code blocks ).

This alert has not occurred in production for 53 days. This fix
appears to have worked:
alphagov/govuk-aws#1097
Let's think about moving this to general documentation and removing the
alert from Icinga if this hasn't reoccured by the time of the next
review ( in another 3 months).

@karlbaker02 karlbaker02 temporarily deployed to govuk-developer-docs-f-pr-2219 Jan 10, 2020 Inactive

```bash
$ cd govuk-aws
$ tools/build-terraform-project.sh -c plan -p app-mongo -s blue -d data -e integration # Please check the script to identify the keys
```

1. The out-put, will show you the components and how they are named by `terraform`.
4. The out-put, will show you the components and how they are named by `terraform`.

This comment has been minimized.

Copy link
@issyl0

issyl0 Jan 10, 2020

Member
Suggested change
4. The out-put, will show you the components and how they are named by `terraform`.
4. The output, will show you the components and how they are named by `terraform`.

This comment has been minimized.

Copy link
@camdesgov

camdesgov Jan 14, 2020

Author Contributor

Good spot. I've just pushed your correction, could you take another look?

Fix typo.

Fix numbering (markdown automatic numbering doesn't
work correctly after code blocks ).

This alert has not occurred in production for 53 days. This fix
appears to have worked:
alphagov/govuk-aws#1097
Let's think about moving this to general documentation and removing the
alert from Icinga if this hasn't reoccured by the time of the next
review ( in another 3 months).
@issyl0
issyl0 approved these changes Jan 14, 2020
@camdesgov camdesgov merged commit a16ac3c into master Jan 15, 2020
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@camdesgov camdesgov deleted the review-recreate-mongo branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.