Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pull request guide #2288

Merged
merged 1 commit into from Feb 6, 2020
Merged

Bump pull request guide #2288

merged 1 commit into from Feb 6, 2020

Conversation

@injms
Copy link
Contributor

injms commented Feb 5, 2020

Just a bump, since it's all up to date.

Next review it could be worth swapping "unofficial" hub with official gh - gh is probably too early in development to be recommended at the moment.

 - Next review it could be worth swapping "unofficial" `hub` with official
   [`gh`](https://github.com/cli/cli) - `gh` is probably too early in
   development to be recommended at the moment.
@issyl0
issyl0 approved these changes Feb 6, 2020
Copy link
Member

issyl0 left a comment

hub currently does more stuff than gh. With the new gh tool tho, hub is a wrapper around git and gh is a wrapper around GitHub. I assume that at some point gh will supersede hub entirely. But my muscle memory still types hub for things that gh works for - like gh pr checkout. But hub clone alphagov/govuk-developer-docs doesn't have an equivalent in gh.

@injms injms merged commit 954d425 into master Feb 6, 2020
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@injms injms deleted the bump-pull-request-guide branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.