Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publishing components gem to dashboard #350

Merged
merged 1 commit into from Aug 7, 2017
Merged

Add publishing components gem to dashboard #350

merged 1 commit into from Aug 7, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 28, 2017

A gem to document components in GOV.UK frontend applications
https://github.com/alphagov/govuk_publishing_components

@tijmenb tijmenb temporarily deployed to govuk-tech-docs-pr-350 Jul 28, 2017 Inactive
@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 28, 2017

Looks like a problem deploying the review app, cc @tijmenb

@SamLR
Copy link
Contributor

@SamLR SamLR commented Aug 7, 2017

This looks ok but I don't know whether the comment about bad heroku deploy is still valid. @fofr can you push again to trigger another build?

A gem to document components in GOV.UK frontend applications
https://github.com/alphagov/govuk_publishing_components
@fofr fofr force-pushed the add-component-gem branch from 43686ae to 1094cc4 Aug 7, 2017
@fofr
Copy link
Contributor Author

@fofr fofr commented Aug 7, 2017

@SamLR I've pushed again after a rebase with master but it looks like it hasn't triggered another review build.

@SamLR
Copy link
Contributor

@SamLR SamLR commented Aug 7, 2017

@tijmenb is this something that needs to be checked or can we just merge?

@tijmenb tijmenb temporarily deployed to govuk-tech-docs-pr-350 Aug 7, 2017 Inactive
@fofr
Copy link
Contributor Author

@fofr fofr commented Aug 7, 2017

@SamLR
Copy link
Contributor

@SamLR SamLR commented Aug 7, 2017

@fofr I can't access that : \

@SamLR
Copy link
Contributor

@SamLR SamLR commented Aug 7, 2017

LGTM merge away (& thanks)

@SamLR
SamLR approved these changes Aug 7, 2017
@fofr fofr merged commit 0f6b1bb into master Aug 7, 2017
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the add-component-gem branch Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.