Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend components page to manual #400

Merged
merged 1 commit into from Sep 1, 2017
Merged

Add frontend components page to manual #400

merged 1 commit into from Sep 1, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Sep 1, 2017

Detail what components are, where principles and conventions live and where to find component guides.

@tijmenb tijmenb temporarily deployed to govuk-tech-docs-pr-400 Sep 1, 2017 Inactive
## Building components

A component must:
* [meet the component principles](https://github.com/alphagov/govuk_publishing_components/blob/master/docs/component_principles.md)

This comment has been minimized.

@andysellick

andysellick Sep 1, 2017
Contributor

I think there needs to be an empty line here - it's not rendering the list properly.

This comment has been minimized.

@fofr

fofr Sep 1, 2017
Author Contributor

Fixed 👍


Find components in these guides:

* [static component guide](https://govuk-static.herokuapp.com/component-guide/)

This comment has been minimized.

@andysellick

andysellick Sep 1, 2017
Contributor

This link doesn't work yet - I assume that's okay?

This comment has been minimized.

@fofr

fofr Sep 1, 2017
Author Contributor

It'll work now.

Detail what components are, where principles and conventions live and
where to find component guides.
@fofr fofr merged commit 1c6a029 into master Sep 1, 2017
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the frontend-manual branch Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.