Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add how-to address issue with new Ruby release #202

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@benthorner
Copy link
Contributor

commented Oct 3, 2019

No description provided.

README.md Show resolved Hide resolved
README.md Outdated
ruby-build: definition not found: x.y.z
```

Most of our services share a common image, which we needs rebuilding to be aware of the new Ruby version. So, to fix the error, run the following commands, where `<service>` is e.g. `collections-publisher`.

This comment has been minimized.

Copy link
@huwd

huwd Oct 3, 2019

Is it work stating "docker image"? I know this is a docker repo, but i always find image a slippery word!

This comment has been minimized.

Copy link
@benthorner

benthorner Oct 3, 2019

Author Contributor

Sure. I notice we've used 'Docker container' elsewhere too, so it seems like we have a precedent of being specific. Updated 👍.

README.md Outdated
ruby-build: definition not found: x.y.z
```

Most of our services share a common image, which we needs rebuilding to be aware of the new Ruby version. So, to fix the error, run the following commands, where `<service>` is e.g. `collections-publisher`.

This comment has been minimized.

Copy link
@JonathanHallam

JonathanHallam Oct 3, 2019

I think this might be clearer along the lines of
So, to fix the error, run the following commands, replacing '<service>' with the name of the service, e.g. 'collections-publisher'
Fully recognise that this is a bit pedantic though so am approving :)

This comment has been minimized.

Copy link
@issyl0

issyl0 Oct 3, 2019

Member

I agree with Jon. And remove the "So,"?

This comment has been minimized.

Copy link
@benthorner

benthorner Oct 3, 2019

Author Contributor

Sure. Updated 👍.

Copy link

left a comment

Really clear, I like it.
Wonder if it could be improved by a final "you'll know this is fixed when x" line.
Also question about docker images.

@benthorner benthorner force-pushed the add-new-ruby-how-to branch 2 times, most recently from dc35954 to 3959851 Oct 3, 2019
@benthorner

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

@huwd thanks for the comments :-). In answer to your question about when someone will know this is fixed, it's as simple as "you won't get the error anymore".

README.md Outdated
ruby-build: definition not found: x.y.z
```

Most of our services share a common Docker image, which we needs rebuilding to be aware of the new Ruby version. To fix the error, run the following commands, replacing '<service>' with the name of the service, e.g. 'collections-publisher'.

This comment has been minimized.

Copy link
@maxgds

maxgds Oct 3, 2019

Remove "we" from "which we needs rebuilding"

This comment has been minimized.

Copy link
@benthorner

benthorner Oct 3, 2019

Author Contributor

Good spot - updated 👍.

@benthorner benthorner force-pushed the add-new-ruby-how-to branch from 3959851 to a13f690 Oct 3, 2019
@benthorner

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

Blimey - my PR is getting a lot of love 😃.

@benthorner

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

After discussing this offline with @huwd, I think we're good to merge...

@benthorner benthorner merged commit 4bf6f4e into master Oct 3, 2019
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@benthorner benthorner deleted the add-new-ruby-how-to branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.