Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maslow to GOV.UK Docker #304

Merged
merged 1 commit into from Feb 5, 2020
Merged

Add Maslow to GOV.UK Docker #304

merged 1 commit into from Feb 5, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 5, 2020

  • Platform Health are upgrading this app to Rails 6, so I felt it was a
    good idea to make it runnable with GOV.UK Docker like the rest of the
    apps.

https://trello.com/c/1TKgm8xV/1743-add-maslow-to-govuk-docker

@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Feb 5, 2020

I tested this with govuk-docker run maslow-lite bundle exec rake and all the tests passed. Running this in a browser, I get a GDS SSO error message, but that's to be expected as I've not replicated data yet so there are no users.

@issyl0 issyl0 force-pushed the maslow branch 2 times, most recently from b5bca06 to 11934db Feb 5, 2020
@benthorner

This comment has been minimized.

Copy link
Contributor

benthorner commented Feb 5, 2020

With the web app, I think we should be using the Content Store approach, since the DB setup needs to be a little different for Mongo - this should mean a 'dev user' gets created.

@issyl0 issyl0 force-pushed the maslow branch from 11934db to 1fb3b08 Feb 5, 2020
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Feb 5, 2020

@benthorner Also done! That makes sense.

- Platform Health are upgrading this app to Rails 6, so I felt it was a
  good idea to make it runnable with GOV.UK Docker like the rest of the
  apps.
@issyl0 issyl0 force-pushed the maslow branch from 1fb3b08 to 8eac701 Feb 5, 2020
Copy link
Contributor

benthorner left a comment

Nice - works for me!

@issyl0 issyl0 merged commit bc88c30 into master Feb 5, 2020
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@issyl0 issyl0 deleted the maslow branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.