New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for attributes on table cells #1045

Merged
merged 2 commits into from Oct 29, 2018

Conversation

Projects
None yet
3 participants
@jonheslop
Copy link
Contributor

jonheslop commented Oct 29, 2018

It’s currently not possible to attach HTML attributes to table cells.
This PR makes it possible by using the same object pattern that is used
on other components (and also the <table> element).

I’ve updated the nunjucks template as well as the YAML and the README
to reflect the new functionality.

Background

Whilst migrating https://github.com/alphagov/pay-selfservice I’ve tried to use macros where ever possible, but we regularly use ID’s on cells within table so that our various tests can easily get the value.

Add support for attributes on table cells
It’s currently not possible to attach HTML attributes to table cells.
This PR makes it possible by using the same object pattern that is used
on other components (and also the <table> element).

I’ve updated the nunjucks template as well as the YAML and the README
to reflect the new functionality.

@jonheslop jonheslop force-pushed the jonheslop:add-support-for-attributes-on-table-cells branch from 3c77f32 to 5d9b8fd Oct 29, 2018

@igloosi
Copy link
Contributor

igloosi left a comment

this looks good 👍
Thanks very much for the feature. We do require a second approval from the team before merging.

@igloosi igloosi added this to the [NEXT] milestone Oct 29, 2018

@jonheslop jonheslop force-pushed the jonheslop:add-support-for-attributes-on-table-cells branch 2 times, most recently from 362aff3 to c255929 Oct 29, 2018

@nickcolley
Copy link
Contributor

nickcolley left a comment

Excellent work Jon thanks.

@igloosi igloosi merged commit f8b816f into alphagov:master Oct 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jonheslop jonheslop deleted the jonheslop:add-support-for-attributes-on-table-cells branch Oct 29, 2018

@jonheslop

This comment has been minimized.

Copy link
Contributor

jonheslop commented Oct 29, 2018

Yay! Thanks :D

@igloosi igloosi referenced this pull request Nov 1, 2018

Merged

Release v2.3.0 #1047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment