Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update links (and things that look like links) to use the new focus style #1309
Implementation of the focus iteration.
Updates components and styles that mostly look like 'links' including:
Error summary links
Internet explorer 8 does not have support for box-shadow, to meet the WCAG 2.1 requirements we intentionally unset the outline and allow the user-agent style to appear which looks like the following:
We've found some rendering issues with Edge 18 and Internet Explorer 11
You can see that in Edge 18, all custom focus styles are broken, the following example is of www.GOV.UK that is not using our new focus styles.
Internet Explorer 11
According to this, https://en.wikipedia.org/wiki/Microsoft_Edge#Chromium_(2019%E2%80%93present) the chromium version of Edge is going to be fall this year
You can see for a browser like Chrome, that it takes maybe 2-3 months before most people migrate to the latest version http://gs.statcounter.com/browser-version-market-share
So we're looking at Edge being fixed end of the year, early next year.
For Internet Explorer / Edge traffic:
Overall IE11 and Edge 18 will have around 13% share of our users for at least 7-8months, if not more.
Edge 18 has quite problematic issues but this can be seen on any website using custom
Edge 19+ will be using the Chromium rendering engine so this will not be an issue.
Edge 17 and below, and IE 9-11 have lesser issues that we have determined will not cause a barrier.
See: https://gist.github.com/nickcolley/3788eefd34e7f04391de07867a85018b for an example of how
With all this in mind we're going to raise a bug report with the Edge team to make them aware of this problem that was introduced in Edge 18 (with previous versions behaving like Internet Explorer).
We have also decided to continue with the rendering issues with Internet Explorer 11 as we think the focus styles are still an improvement over user-agent styling.
Also fixes #1236