Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add new focus style to buttons #1315
Looking good so far
It also appears to have lost the margin-top that is applied in this state to give the button it's "pushed down" feel
nickcolley left a comment
In Dave's original design, the focus style is not shown when the user is actively (:active) pressing the button, or hovering over the button (:hover).
In this iteration, active works but hover still shows the focus. You could consider something like
Additional to this, the secondary and warning buttons show the focus state when actively pressing the buttons.