Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline the frontend module #144

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Inline the frontend module #144

merged 1 commit into from
Jan 22, 2021

Conversation

richardTowers
Copy link
Contributor

This gets rid of another layer of variables / outputs which we have to
pass around.

It should be possible to confirm this is a no-op by doing some terraform state mv commands before running the plan.

Copy link
Contributor

@fredericfran-gds fredericfran-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

This gets rid of another layer of variables / outputs which we have to
pass around.

It should be possible to confirm this is a no-op by doing some `terraform
state mv` commands before running the plan.
Copy link
Contributor

@fredericfran-gds fredericfran-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, I thought you checked the no-op already.

@richardTowers
Copy link
Contributor Author

😅 no, I only opined that "it should be possible to confirm this is a no-op" ... I didn't actually confirm it! (But I have now)

@richardTowers richardTowers merged commit 0eaa940 into main Jan 22, 2021
@richardTowers richardTowers deleted the inline-frontend-module branch January 22, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants