Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add Sass linting #30
Begin using SCSS Lint to lint our style files:
Differences with rubocop:
Begin using SCSS Lint to lint our style files: https://github.com/brigade/scss-lint https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/RE ADME.md Start with the default config.
* Hide options for disabled linters * Turn off declaration order (eg @extend first), will be difficult to fix * Don’t care about Hex length for now – should use variables for the most part * There are some known good uses of !important, we don’t have an excessive use of !important problem * Don’t have opinions on .5em vs 0.5em * Turn off property sort order, would create lots of noise to fix * Turn off property spelling, new CSS features will give false positives * Turn off property units, we advise on this in the style guide but the advice isn’t extensive or adhered to * Turn off pseudo element checks, older browsers use single colons rather than double * In qualifying element, allow the likes of `div[aria-hidden]` * Disable SelectorDepth checks, we might want to enable this later, but for reducing noise turn off for now * Turn off StringQuotes checking, we might want to re-enable later based on what would be reported * Enable trailing zero checks (0.500em should be 0.5em) * Enable transition all checks - bad for performance, unlikely we will have this problem though * Disable vendor prefix checks, we do this manually, perhaps we shouldn’t
Would it be possible to only specify the options where we deviate from the defaults in
@fofr and I discussed the linting rules offline, and these are a good set of rules to start with, but we can always tighten them later. Not having a diff mode is less of an issue, as the amount of
Only issue i've encountered is a
I'm not a
I was able to resolve the frontend app dependency issue with
Otherwise this LGTM, and i'd be happy with it being merged.