Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Check Your Answers page #36

Merged
merged 14 commits into from Nov 16, 2015

Conversation

@rivalee
Copy link
Contributor

commented Oct 21, 2015

Adding a simple Check Your Answers page to the Prototype Kit examples:

screencapture-localhost-3000-examples-check-your-answers-1445420427730

@joelanman

This comment has been minimized.

Copy link
Member

commented Oct 21, 2015

Is the data all definitely fake? For example the full address, and telephone number?

@quis

This comment has been minimized.

Copy link
Member

commented Oct 21, 2015

We've always had the row headings top-aligned. Is the vertical centering intentional? I think it makes the relationship of the information less clear, for example if you were using a nasty screen that blew out the keylines:

image

@joelanman

This comment has been minimized.

Copy link
Member

commented Oct 21, 2015

+1 to top aligned - also might it look better in a 2/3 column? I'm always worried about the change links not being so clear, floating so far away.

@edwardhorsford

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2015

+1 top aligned.

For the visually hidden text after 'change' I'd be tempted to do "Change Exporter name" rather than "Change answer 1. Exporter". But perhaps this is more consistent. Thoughts?

Should some of the text in the answers section be promoted to sections? Eg having 'tel:xxxx' feels odd to me. The section is exporter, and then the label is telephone. Or am I being crazy?

rivalee and others added some commits Oct 19, 2015

Add and import a check your answers scss file
- Set the text size to be 19px, the same as body text
- Vertically-align table cell content to the top
- Right align the “change” link
Amend check your answers example
- Remove unused classes
- Make example content generic
- Fix indentation
- Apply pattern styles to the table

@gemmaleigh gemmaleigh force-pushed the check-your-answers branch from f5b9cea to 3a1b218 Oct 30, 2015

@gemmaleigh

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2015

This has been updated, screenshot here:

check your answers

  • Example has been shortened
  • Text for the answers is more generic
  • Content is top aligned.
@timpaul

This comment has been minimized.

@rivalee rivalee force-pushed the check-your-answers branch from 540e1eb to 3a1b218 Nov 2, 2015

timpaul added a commit that referenced this pull request Nov 16, 2015

@timpaul timpaul merged commit 795a0b6 into master Nov 16, 2015

@timpaul timpaul referenced this pull request Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.