Skip to content
Permalink
Branch: master
Commits on Jan 14, 2020
  1. Merge pull request #10050 from alphagov/make-check_reboots_required-f…

    issyl0 committed Jan 14, 2020
    …ormatting-better
    
    check_reboots_required: Make AWS hosts list formatting better
  2. check_reboots_required: Make AWS hosts list formatting better

    issyl0 committed Jan 14, 2020
    - After we fixed the generation of this data (), this was still a little
      verbose.
    
    Before:
    
    ```
    These hosts should reboot automatically overnight:
    - router-backend-1 with hostname: ip-10-13-4-147.eu-west-1.compute.internal
    ```
    
    After:
    
    ```
    These hosts should reboot automatically overnight:
    - ip-10-13-4-147.eu-west-1.compute.internal (router-backend-1)
    ```
  3. Merge pull request #10049 from alphagov/fix-govuk_node_list-with-pupp…

    issyl0 committed Jan 14, 2020
    …et-class-option
    
    Fix `govuk_node_list --with-puppet-class` to show all the hosts
  4. Refactor `--with-puppet-class` code to be more Pythonic

    issyl0 and thomasleese committed Jan 14, 2020
    Co-Authored-By: Thomas Leese <thomas.leese@digital.cabinet-office.gov.uk>
  5. Fix `govuk_node_list --with-puppet-class` to show all the hosts

    issyl0 committed Jan 14, 2020
    - We were doing on-call out of hours reboots this morning and noticed
      that on the AWS side none of the AWS hostnames made any sense. "It
      would be nice if the reboot check could show what class of machine
      that is". This would avoid us having to login to the AWS Console,
      search the EC2 section for the hostname and _then_ check against the
      reboots doc.
    - Turns out this will already work, but only if the
      `govuk_node_list` command it relies on works properly itself.
    - Before, the `--with-puppet-class` function wasn't iterating through
      the instances properly as the `return` statement was returning the
      first instance it found (in all my testing, either `mongo-1` or
      `whitehall-backend-1`). This fixes it so that rather than:
    
    ```
    $ govuk_node_list --with-puppet-class
    ip-10-1-6-48.eu-west-1.compute.internal:whitehall-backend-1
    $
    ```
    
      it returns all the values:
    
    ```
    $ govuk_node_list --with-puppet-class
    [...]
    ip-10-1-6-231.eu-west-1.compute.internal:content-store-1
    ip-10-1-6-45.eu-west-1.compute.internal:draft-cache-1
    ip-10-1-6-185.eu-west-1.compute.internal:cache-1
    ip-10-1-6-4.eu-west-1.compute.internal:rabbitmq
    ip-10-1-6-48.eu-west-1.compute.internal:whitehall-backend-1
    $
    ```
    
    https://trello.com/c/dw9iaOBM/1676-improve-reboot-required-icinga-check-wording
  6. Merge pull request #10048 from alphagov/reboot-required-wording

    issyl0 committed Jan 14, 2020
    Note "automatically" in "these hosts should reboot overnight":
  7. Note "automatically" in "these hosts should reboot overnight":

    issyl0 committed Jan 14, 2020
    - As someone doing on-call out-of-hours reboots for the first time,
      bleary-eyed early this morning, it wasn't entirely clear to me that
      the overnight hosts were automatic from the existing wording.
Commits on Jan 8, 2020
  1. Merge pull request #10026 from alphagov/remove-terraform-docs-from-ci

    issyl0 committed Jan 8, 2020
    Fully remove `terraform-docs` package
  2. Fully remove `terraform-docs` package

    issyl0 committed Jan 8, 2020
    - Follow up to #9974.
You can’t perform that action at this time.