Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_reboots_required: Make AWS hosts list formatting better #10050

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Jan 14, 2020

  • After we fixed the generation of this data, this was still a little verbose.

Before:

These hosts should reboot automatically overnight:
- router-backend-1 with hostname: ip-10-13-4-147.eu-west-1.compute.internal

After:

These hosts should reboot automatically overnight:
- ip-10-13-4-147.eu-west-1.compute.internal (router-backend-1)
- After we fixed the generation of this data (), this was still a little
  verbose.

Before:

```
These hosts should reboot automatically overnight:
- router-backend-1 with hostname: ip-10-13-4-147.eu-west-1.compute.internal
```

After:

```
These hosts should reboot automatically overnight:
- ip-10-13-4-147.eu-west-1.compute.internal (router-backend-1)
```
@issyl0 issyl0 merged commit 28474c6 into master Jan 14, 2020
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@issyl0 issyl0 deleted the make-check_reboots_required-formatting-better branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.