Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Terraboard from the infrastructure #10130

Merged
merged 2 commits into from Feb 11, 2020
Merged

Remove Terraboard from the infrastructure #10130

merged 2 commits into from Feb 11, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 7, 2020

  • Terraboard was introduced in 2018 to help us track Terraform state between environments, to help with the AWS migration.

  • Since then, it hasn't got much use - mostly, we don't remember it exists. It hasn't helped with the goal of keeping environments in sync if any of the recent Terraform deploy diffs are anything to go by.

  • It uses an old, unmaintained version of OAuth2 Proxy which we've had to build a custom Docker image for. Both of these projects are now archived.

  • There's documentation on the required engineering work to get us up to date and stop maintaining so much custom code. This has recently (2020) increased because GitHub are deprecating the authentication APIs that v2.2.0 uses and will keep sending emails every three days until we stop using it.

  • Doing that engineering work will - we hypothesize - cost more than the value that Terraboard currently provides. So, delete Terraboard. To add some weight to this, a recent poll that I did in Slack had most respondents on the item "is a Terraboard an upside down Hoverboard", indicating that most devs had never heard of it.

  • Other considerations included: getting rid of OAuth2_Proxy because Terraboard is behind office IP restrictions on AWS. But: is Terraboard that valuable as a thing?

- Terraboard was [introduced in 2018](#8143) to help us track Terraform state between environments, to help with the AWS migration.

- Since then, it hasn't got much use - mostly, we don't remember it exists. It hasn't helped with the goal of keeping environments in sync if any of the recent [Terraform deploy diffs](https://ci-deploy.integration.publishing.service.gov.uk/job/Deploy_Terraform_GOVUK_AWS/) are anything to go by.

- It uses an old, unmaintained version of OAuth2 Proxy which we've had to build a [custom Docker image](https://github.com/alphagov/govuk-oauth2-proxy-docker/blob/master/Dockerfile) for. Both of these projects are now archived.

- There's [documentation on the required engineering work](https://github.com/alphagov/govuk-developer-docs/blob/5ce8d7bd10cdceb7b89309ae388a41016dd2ab64/source/manual/use-terraboard-to-monitor-terraform-state.html.md#docker-image-for-oauth2-proxy) to get us up to date and stop maintaining so much custom code. This has recently (2020) increased because [GitHub are deprecating the authentication APIs that v2.2.0 uses](https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters) and will keep sending emails every three days until we stop using it.

- Doing that engineering work will - we hypothesize - cost more than the value that Terraboard currently provides. So, delete Terraboard. To add some weight to this, a recent poll that I did in Slack had most respondents on the item "is a Terraboard an upside down Hoverboard", indicating that most devs had never heard of it.

- Other considerations included: getting rid of OAuth2_Proxy because Terraboard is behind office IP restrictions on AWS. But: is Terraboard that valuable as a thing?
@thomasleese thomasleese requested a review from sengi Feb 7, 2020
Copy link
Contributor

thomasleese left a comment

Worth getting a few more approvals!

Copy link
Contributor

cbaines left a comment

I've never found it valuable. I'm not sure if I tried using it right, but it seemed just a fancy way to view state information. 👍

@sengi
sengi approved these changes Feb 10, 2020
issyl0 added a commit to alphagov/govuk-aws that referenced this pull request Feb 11, 2020
Relates to alphagov/govuk-puppet#10130, but in summary: it's unused.
@issyl0 issyl0 merged commit 2108a0f into master Feb 11, 2020
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@issyl0 issyl0 deleted the rm-terraboard branch Feb 11, 2020
@issyl0 issyl0 mentioned this pull request Feb 11, 2020
issyl0 added a commit that referenced this pull request Feb 11, 2020
- Now that #10130 is deployed in all AWS environments to `ensure =>
  absent` the resources.
@issyl0 issyl0 mentioned this pull request Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.