Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the `gds-nagios-plugins` package #10145

Merged
merged 1 commit into from Feb 14, 2020
Merged

Remove the `gds-nagios-plugins` package #10145

merged 1 commit into from Feb 14, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 14, 2020

  • We've moved everything that used to be here out of
    alphagov/nagios-plugins and into the plugins directory of this repo.

This is draft because we need #10144 merged and deployed first.

@issyl0 issyl0 force-pushed the rm-gds-nagios-plugins branch from 99d3346 to 4b45764 Feb 14, 2020
@issyl0 issyl0 changed the title Start to remove the `gds-nagios-plugins` package Remove the `gds-nagios-plugins` package Feb 14, 2020
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Feb 14, 2020

Wait, we probably need to pip uninstall this otherwise it'll linger forever.

@issyl0 issyl0 force-pushed the rm-gds-nagios-plugins branch from 4b45764 to 6382161 Feb 14, 2020
@issyl0 issyl0 marked this pull request as ready for review Feb 14, 2020
Copy link
Contributor

barrucadu left a comment

Not sure if it'll complain about trying to uninstall a specific version (rather than just uninstalling the package), but we can try it

- We've moved everything that used to be here out of
  alphagov/nagios-plugins and into the plugins directory of this repo.
@issyl0 issyl0 force-pushed the rm-gds-nagios-plugins branch from 6382161 to 43e4afe Feb 14, 2020
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Feb 14, 2020

Good point. I removed the version constriaint.

@issyl0 issyl0 merged commit bb470c1 into master Feb 14, 2020
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@issyl0 issyl0 deleted the rm-gds-nagios-plugins branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.