Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert no-cache rule for front-end homepage #4353

Merged
merged 2 commits into from Apr 25, 2016
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 21, 2016

The code to remove non-js tracking has been removed in:
alphagov/frontend#944

Also remove the corresponding parts added in:
https://github.gds/gds/puppet/pull/978
003254a
e10bc99

The code to remove non-js tracking is being removed in
alphagov/frontend#944

We should also remove the parts added here, in:
https://github.gds/gds/puppet/pull/978
003254a
707ccba7367c1adf
e10bc99
cc6a0129b846582e
} else {
$nginx_extra_config = ''
}
$nginx_extra_config = ''

This comment has been minimized.

@boffbowsh

boffbowsh Apr 21, 2016
Contributor

You can remove this line and the parameter from the govuk::app declaration below, as the default is ''

This comment has been minimized.

@fofr

fofr Apr 22, 2016
Author Contributor

Updated in ea2604f

The default value is `''`
@boffbowsh boffbowsh merged commit 1b7e67d into master Apr 25, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default "Build #18107 succeeded on Jenkins"
Details
@boffbowsh boffbowsh deleted the revert-non-js-tracking branch Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.