Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the search-api index size metric names (take 2) #9315

Merged
merged 1 commit into from Jun 25, 2019

Conversation

Projects
None yet
2 participants
@cbaines
Copy link
Contributor

commented Jun 24, 2019

Re-do the changes from [1] that were removed in [2].

1: 6ba8846
2: 9811d5b

Metrics ending in .count are usually used for timers in StatsD, and
there is some specific Graphite storage aggregation configuration for
them [3].

This change updates the use of the metrics to match the new name [4].

3: https://github.com/alphagov/govuk-puppet/blob/master/modules/govuk/files/node/s_graphite/storage-aggregation.conf#L35-L40

[count]
pattern = \.count$
aggregationMethod = sum
xFilesFactor = 0.1

4: alphagov/search-api#1577

Update the search-api index size metric names (take 2)
Re-do the changes from [1] that were removed in [2].

1: 6ba8846
2: 9811d5b

Metrics ending in `.count` are usually used for timers in StatsD, and
there is some specific Graphite storage aggregation configuration for
them [3].

This change updates the use of the metrics to match the new name [4].

3: https://github.com/alphagov/govuk-puppet/blob/master/modules/govuk/files/node/s_graphite/storage-aggregation.conf#L35-L40
```
[count]
pattern = \.count$
aggregationMethod = sum
xFilesFactor = 0.1
```

4: alphagov/search-api#1577
@bilbof

bilbof approved these changes Jun 25, 2019

@cbaines cbaines merged commit c76534c into master Jun 25, 2019

1 check passed

continuous-integration/jenkins/branch This commit looks good
Details

@cbaines cbaines deleted the update-search-api-index-names-take-2 branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.