Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak bootstrap-sass pin and navbar logic #116

Merged
merged 3 commits into from Jan 4, 2016
Merged

Tweak bootstrap-sass pin and navbar logic #116

merged 3 commits into from Jan 4, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 31, 2015

  • Use 3.3.5.1 rather than 3.3.5 as this contains a necessary Sass dependency fix: https://rubygems.org/gems/bootstrap-sass/versions/3.3.5.1. Pinning because bootstrap-sass has a tendency to release breaking changes in point releases.
  • Move navbar logic into variable. Fixes a bug where the collapsed nav icon wouldn’t shown when there are no navbar items but there is a sign out link.
fofr added 3 commits Dec 31, 2015
Use 3.3.5.1 rather than 3.3.5 as this contains a necessary Sass
dependency fix:
https://rubygems.org/gems/bootstrap-sass/versions/3.3.5.1

Pinning because bootstrap-sass has a tendency to release breaking
changes in point releases.
Clarify which bits are dependent on navbar content being present.

Fixes a bug where the collapsed nav icon wouldn’t shown when there are
no navbar items but there is a sign out link.
jamiecobbett added a commit that referenced this issue Jan 4, 2016
Tweak bootstrap-sass pin and navbar logic
@jamiecobbett jamiecobbett merged commit 287a8f7 into master Jan 4, 2016
1 check passed
@jamiecobbett jamiecobbett deleted the tweaks branch Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants