Skip to content
This repository has been archived by the owner. It is now read-only.

Namespace gem assets #12

Merged
merged 2 commits into from May 30, 2014
Merged

Namespace gem assets #12

merged 2 commits into from May 30, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 30, 2014

  • Move CSS and JS into govuk_admin_template subdirectories
fofr added 2 commits May 30, 2014
* Prevent modules and other JS files from clashing with an app’s own
versions
* Prevent clashes with scss files of the same name in parent apps
jamiecobbett added a commit that referenced this pull request May 30, 2014
@jamiecobbett jamiecobbett merged commit 96ce9ce into master May 30, 2014
1 check passed
1 check passed
default "Build #11 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the namespace_assets branch May 30, 2014
@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented May 30, 2014

This is a breaking change, so would ordinarily trigger a major version bump, but it's pre-1.0.0 so you're free to do what you like: http://semver.org/

@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented May 30, 2014

I've misunderstood - it's only a breaking change if a user of the gem was requiring a file directly (which would be weird): the normal "API" is to require a single file - that hasn't changed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.