Skip to content
This repository has been archived by the owner. It is now read-only.

Put back Bootstrap 2 nav-list styles #22

Merged
merged 6 commits into from Jun 12, 2014
Merged

Put back Bootstrap 2 nav-list styles #22

merged 6 commits into from Jun 12, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 9, 2014

  • nav-list is a Bootstrap 2 design pattern heavily used in Publisher, Panopticon and others. Put back the styles for backwards compatibility when upgrading to Bootstrap 3, to avoid substantial redesign.
  • Include examples in style guide, with warning about use of the pattern
  • Clean up style guide visited/normal link hrefs using variables

screen shot 2014-06-09 at 13 05 20

fofr added 6 commits Jun 9, 2014
* Pattern is heavily used in Publisher, Panopticon and other tools
* Include note in style guide about avoiding using it
* Update to use Bootstrap 3 variables
* Remove Bootstrap 2 text shadow flourishes
* Nest styles within nav-list to avoid clashes with newer patterns
* Include example from publisher, with badges
* Clarify purpose of href values of links in style guide
* Make it easier to test visited links
@@ -1,6 +1,8 @@
module GovukAdminTemplate
class StyleGuideController < ApplicationController
def index
@normal_link_href = "#{request.original_url}##{Time.now.utc.to_i}"

This comment has been minimized.

@benilovj

benilovj Jun 9, 2014
Contributor

tiny nitpick: this would probably read better if it were:

@normal_link_href = request.original_url + "#" +Time.now.utc.to_i

This comment has been minimized.

@benilovj

benilovj Jun 9, 2014
Contributor

come to think of it, it might be more a bit more railsy to define these as helper methods in ApplicationHelper, rather than in the controller

This comment has been minimized.

@fofr

fofr Jun 10, 2014
Author Contributor

Should the style guide expand to multiple pages, I'd make the helpers change.
Re: the format, I stuck to the style guide, but I agree, it looks a little odd.

This comment has been minimized.

@benilovj

benilovj Jun 10, 2014
Contributor

Re: the format, I stuck to the style guide, but I agree, it looks a little odd.

The style guide is a guide - I think readability should trump the guide.
but it's a minor point.

@benilovj
Copy link
Contributor

@benilovj benilovj commented Jun 9, 2014

style_guide/index.html.erb is getting a bit long - might be an idea to split it up into partials

@fofr
Copy link
Contributor Author

@fofr fofr commented Jun 10, 2014

You're right about the length of the style guide, it should be split up into partials but I don't think it should be done here.

bishboria added a commit that referenced this pull request Jun 12, 2014
Put back Bootstrap 2 nav-list styles
@bishboria bishboria merged commit 993509c into master Jun 12, 2014
1 check passed
1 check passed
default "Build #32 succeeded on Jenkins"
Details
@bishboria bishboria deleted the nav-list branch Jun 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.