Skip to content
This repository has been archived by the owner. It is now read-only.

Move IE8 shims and fixes so they load after styles #27

Merged
merged 1 commit into from Jun 26, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 26, 2014

For respond.js to work correctly, it must load after the CSS has loaded (it uses media queries in the CSS files to determine styles to display).

Also, from the docs, “Reference the respond.min.js script (1kb min/gzipped) after all of your CSS (the earlier it runs, the greater chance IE users will not see a flash of un-media'd content)”

Before:
screen shot 2014-06-26 at 09 07 33

After:
screen shot 2014-06-26 at 09 07 53

* For respond.js to work correctly, it must load after the CSS has
loaded (it uses media queries in the CSS files to determine styles to
display). Also, from the docs, “Reference the respond.min.js script
(1kb min/gzipped) after all of your CSS (the earlier it runs, the
greater chance IE users will not see a flash of un-media'd content)”
vinayvinay added a commit that referenced this pull request Jun 26, 2014
Move IE8 shims and fixes so they load after styles
@vinayvinay vinayvinay merged commit 3ead79d into master Jun 26, 2014
1 check passed
1 check passed
default "Build #36 succeeded on Jenkins"
Details
@vinayvinay vinayvinay deleted the ie8-respond-fix branch Jun 26, 2014
fofr pushed a commit to alphagov/transition that referenced this pull request Jun 26, 2014
fofr added a commit to alphagov/publisher that referenced this pull request Jun 26, 2014
fofr pushed a commit to alphagov/maslow that referenced this pull request Jun 26, 2014
Paul Hayes
* Fix rendering in IE8, see:
alphagov/govuk_admin_template#27
* Include style fixes to visited links within bootstrap components
fofr added a commit to alphagov/travel-advice-publisher that referenced this pull request Jun 26, 2014
* See: alphagov/govuk_admin_template#27
* Remove use of silent class, replace with mixin (breaking change from
v1.0.0 of admin gem)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.