Skip to content
This repository has been archived by the owner. It is now read-only.

Prevent environment indicator from occasionally wrapping #54

Merged
merged 3 commits into from Dec 5, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 4, 2014

Occasionally the browser would render the environment indicator on a new line. A refresh would sometimes fix, sometimes not even though the code was unchanged.

  • Attempt to fix (the rendering bug isn't easily reproducible) by removing floats and the associated float calculations from the render tree
  • Mark indicator as inline-block and include inline-block IE7 hack
  • Reposition crown background in IE7

(IE7 is currently 2% of admin app sessions)

Example of the bug

screen shot 2014-12-04 at 16 41 38

cc @benilovj

fofr added 3 commits Dec 4, 2014
Occasionally the browser would render the environment indicator on a
new line. A refresh would sometimes fix, sometimes not even though the
code was unchanged.

* Attempt to fix by removing floats and float calculations
* Mark indicator as inline-block and include inline-block IE7 hack
* Reposition crown background in IE7
Without a vertical alignment set different fonts (eg Arial on Windows)
line up less nicely.
Label is an enhancement, it repeats what’s in the domain part of the
URL, which is more obvious on mobile. Prevents wrapping.
@benilovj
Copy link
Contributor

@benilovj benilovj commented Dec 5, 2014

I've tested this against Maslow with Chrome, Firefox and Safari and it's fine. 👍

fofr added a commit that referenced this pull request Dec 5, 2014
Prevent environment indicator from occasionally wrapping
@fofr fofr merged commit df74fdc into master Dec 5, 2014
1 check passed
1 check passed
default "Build #84 succeeded on Jenkins"
Details
@fofr fofr deleted the env-label-position-fix branch Dec 5, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.