Skip to content
This repository has been archived by the owner. It is now read-only.

Workaround interpolation bug in libsass #71

Merged
merged 1 commit into from Jun 19, 2015
Merged

Workaround interpolation bug in libsass #71

merged 1 commit into from Jun 19, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 19, 2015

Whitehall uses libsass for faster compilation of sass files. The libsass implementation has a string interpolation bug, spotted by @boffbowsh and avoided in alphagov/whitehall@f15544e

Whitehall will shortly be using this gem, meaning the sass files must be compatible with libsass. The same fixes should be applied here too.

  • Replace interpolation with unquote
Whitehall uses libsass for faster compilation of sass files. The
libsass implementation has a string interpolation bug, spotted by
@boffbowsh in
alphagov/whitehall@f15544e
e82a19298cbe3

* Replace interpolation with unquote
@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Jun 19, 2015

👍 no merge access

fofr added a commit that referenced this pull request Jun 19, 2015
Workaround interpolation bug in libsass
@fofr fofr merged commit 2d9cf78 into master Jun 19, 2015
1 check passed
1 check passed
default "Build #110 succeeded on Jenkins"
Details
@fofr fofr deleted the libsass branch Jun 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.